Add Networks and Disks to VM details

[rawagner]

No description provided.

[rawagner]

@lizsurette Design doc is using Dropdown Kebab on the right side of the row for item actions but I used Cog from tectonic and I placed it on the left side which is inline with tectonic List views (ie VM List). Do you think we can keep it this way for now, or should I use Dropdown Kebab on the right side ?

[andybraren]

@lizsurette Correct me if I'm wrong Liz (and I can quickly update every screen again if so), but I believe we decided on the right-hand dropdown kebabs rather than Tectonic's left-hand cog. I think it was to align better with OKD? It also gives some room for future left-hand multiselect checkboxes.

I've updated the design doc with the latest (in-progress) screens. We're still working on the editing flow.

[lizsurette]

@rawagner @andybraren I think ultimately we'd love to see all of the table grids make use of the kebab on the right instead of the cog on the left, but for now I guess it probably falls into the category of keep as the cog to align with all of the other views for now :) I think we didn't align the design with this since it sounded like @serenamarie125 was trying to get this change into the next release, but I haven't seen this change quite yet.

[serenamarie125]

@rawagner are you using the PF data grid component? It has the kebab menus.

@lizsurette there is a PR up with that fix awaiting review to be merged for 4.0 ... openshift#432

[rawagner]

@serenamarie125 I cant find data grid in PF, do you mean Table Grid ? That could work. Right now im using tectonic's components but I will convert to Table Grid.

Since we want to show this in thursday's demo, we could merge it and I will convert to Table Grid with kebab menu as a follow up. @mareklibra can you take a look ?

[serenamarie125]

@rawagner @lizsurette i'll leave it up to you. The goal is to move everyone (including OpenShift) to use the PF React component here's the initial PR: patternfly/patternfly-react#594

[lizsurette]

Since we want to show this in thursday's demo, we could merge it and I will convert to Table Grid with kebab menu as a follow up. @mareklibra can you take a look ?

This sounds like a good plan to me!

[lizsurette]

@lizsurette there is a PR up with that fix awaiting review to be merged for 4.0 ... openshift#432

@serenamarie125 excellent, thanks! @andybraren @matthewcarleton - Sounds like we can keep the kebab in our designs then :)

[rawagner]

follow up #95

[rawagner]

Add nic management to VM details [epic-vm-list-views-2.0] [initiative-vm-ops-ui]

[rawagner]

List VM disks [epic-vm-list-views-2.0] [initiative-vm-ops-ui]