Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Lower logo font size #179

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Lower logo font size #179

merged 1 commit into from
Jan 23, 2019

Conversation

rawagner
Copy link

@mareklibra
Copy link

@matthewcarleton, wdyt?

@matthewcarleton
Copy link

This is something I've talked to Patrick about. It seems like this is a css issue. They way the layout is built that logo shouldn't be able to stretch outside it's container like that. I'll follow up with Patrick about this today. Thanks!

@priley86
Copy link

priley86 commented Jan 21, 2019

it looks like the pf4 base resets were disabled in this upstream commit:
openshift@02ba4c7#diff-6dbc2aec46416806ac17a0975691677f

although, i'm not entirely sure why. Would have to ask @rhamilto. My guess is logo sizing was not ideal at the time (but we can revisit this in future beta releases of PF). Maybe you can discuss w/ @matthewcarleton when you get some time?

For now, I would suggest sizing it smaller to match PF standard. We can also revisit the SVG and properly brand the text ("Viritualization") later too.
priley86@3cbdd50

screen shot 2019-01-21 at 11 59 02 am

@rhamilto
Copy link

although, i'm not entirely sure why.

'cause @maryshak1996 provided design direction to do so.

@priley86
Copy link

thanks @rhamilto - we can revisit w/ @matthewcarleton again soon.

@maryshak1996
Copy link

@rhamilto hey! I believe that I provide design specs for this a while ago, and some layout/sizing for PF4 has since changed. I'm guessing that this might be where some confusion is coming into play - but I'd be happy to chat with anyone if you need any other design guidance :)

@mareklibra
Copy link

As 1.4 release is getting close, let's merge this as a workaround and fix properly later.

@mareklibra mareklibra merged commit 3471088 into kubevirt:master Jan 23, 2019
@rawagner rawagner deleted the logo_font_size branch January 29, 2019 11:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants