Skip to content
This repository has been archived by the owner on Apr 28, 2020. It is now read-only.

export v2v request functions + few fixes #558

Merged
merged 1 commit into from
Oct 14, 2019

Conversation

atiratree
Copy link
Contributor

  • add secret owner references
  • move selectors for clearer approach
  • support unit when creating PVCs
  • let startV2VVMWareController behave like a promise

required by openshift/console#2964

- add secret owner references
- move selectors for clearer approach
- support unit when creating PVCs
- let startV2VVMWareController behave like a promise

Signed-off-by: suomiy <[email protected]>
@coveralls
Copy link

coveralls commented Oct 13, 2019

Pull Request Test Coverage Report for Build 1962

  • 4 of 16 (25.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 82.61%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/k8s/requests/v2v/correctVCenterSecretLabels.js 0 1 0.0%
src/k8s/requests/v2v/startV2VvmwareController.js 0 1 0.0%
src/k8s/requests/v2v/importVmware.js 3 7 42.86%
src/k8s/requests/v2v/createV2VvmwareObject.js 1 7 14.29%
Files with Coverage Reduction New Missed Lines %
src/k8s/requests/v2v/startV2VvmwareController.js 1 11.86%
Totals Coverage Status
Change from base Build 1957: -0.2%
Covered Lines: 4205
Relevant Lines: 4870

💛 - Coveralls

@mareklibra mareklibra merged commit 5fcf520 into kubevirt:master Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants