Skip to content
This repository has been archived by the owner on Apr 28, 2020. It is now read-only.

Improve empty network name message #472

Merged
merged 1 commit into from
May 21, 2019
Merged

Improve empty network name message #472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/Wizard/CreateVmWizard/NetworksTab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {
PXE_INFO,
ERROR_NETWORK_NOT_SELECTED,
ERROR_EMPTY_ENTITY,
ERROR_EMPTY_NAME,
NETWORK_ERROR_EMPTY_NAME,
ERROR_NETWORK_NOT_FOUND,
PXE_NIC,
HEADER_MAC,
Expand All @@ -37,7 +37,7 @@ const validateNetwork = network => {
}

if (!network.name) {
errors[1] = ERROR_EMPTY_NAME;
errors[1] = NETWORK_ERROR_EMPTY_NAME;
}

if (network.id !== 1 && !network.network) {
Expand Down
2 changes: 1 addition & 1 deletion src/components/Wizard/CreateVmWizard/strings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ export const STEP_STORAGE = 'Storage';
export const STEP_RESULT = 'Result';
export const NEXT = 'Next';
export const ERROR_EMPTY_ENTITY = 'Empty entity';
export const ERROR_EMPTY_NAME = 'Name is empty';
export const ERROR_IS_REQUIRED = 'is required';

// VmSettingsTab
Expand Down Expand Up @@ -55,6 +54,7 @@ export const HEADER_NETWORK = 'Network Configuration';
export const ERROR_NETWORK_NOT_FOUND = 'Network config not found';
export const ERROR_NETWORK_NOT_SELECTED = 'Network config must be selected';
export const HEADER_BINDING_METHOD = 'Binding method';
export const NETWORK_ERROR_EMPTY_NAME = 'Network name cannot be empty';

// StorageTab
export const ERROR_NO_BOOTABLE_DISK = 'A bootable disk could not be found';
Expand Down