Do not close Create VM Wizard when clicked outside of modal

[rawagner]

https://bugzilla.redhat.com/show_bug.cgi?id=1710888

[coveralls]

Pull Request Test Coverage Report for Build 1640

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 84.002%

---

Totals
Change from base Build 1895:	0.0%
Covered Lines:	3958
Relevant Lines:	4515

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 1931

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 84.023%

---

Totals
Change from base Build 1662:	0.0%
Covered Lines:	3974
Relevant Lines:	4532

---

💛 - Coveralls

[atiratree]

IMO this is a feature, not a bug :) Users should know what to expect from escape key.

[atiratree]

not sure about the backdrop click

[mareklibra]

I like this change.
Former behaviour was annoying to me.

[andybraren]

No other modal (that I can find) closes itself when clicking on the backdrop, so I agree that annoying behavior should be changed. 🙂

I'm not sure about disabling the Esc key though. The new PF4 wizard supports using Esc to close for accessibility reasons I believe, and existing modals within the Console can be Esc'd to close too. Is hitting Esc and accidentally closing the modal a frequent problem?

[matthewcarleton]

+1 to @andybraren comment about the "esc" key. For more information: https://www.w3.org/TR/wai-aria-practices/examples/dialog-modal/dialog.html and here's a good write up on it too https://simplyaccessible.com/article/closing-modals/

[rawagner]

@andybraren @matthewcarleton thank you for the input! I changed it to not close when user clicks outside of modal (which was pretty annoying), esc is unchanged.