-
Notifications
You must be signed in to change notification settings - Fork 30
refactor v2v, basicSettings and CreateVmDialog + fix bugs #417
Conversation
atiratree
commented
Apr 27, 2019
- renamed basiceSettings -> vmSettings
- updated enhancedK8sMethods
8896edf
to
6804d8d
Compare
- renamed basiceSettings -> vmSettings - updated enhancedK8sMethods
6804d8d
to
f378eee
Compare
Pull Request Test Coverage Report for Build 1695
💛 - Coveralls |
There are many data flows and side effects in vm dialog. Other tabs/extensions(v2v) need to change data as a whole of all dialog. I resolved this by adding custom reducers which react on state updates. I guess you know what should be the next step :) Let's discuss what is the best approach how to continue. @mareklibra @rawagner @vojtechszocs Currently approach:
I tried to separate requests from the ui code but it still needs some work (the best solution would be probably saga) |
merging; with future followups in mind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch is too huge for review. Especially after its merge.
It contains non-v2v changes (refactoring).
The only option we have now is to test it and react on bugs afterwards.
Next time, I would prefer to postpone such huge/unnecessary change after creation of stable branch in project phase like we have these days.
import { VALIDATION_INFO_TYPE } from '../../constants'; | ||
import { prefixedId } from '../../utils'; | ||
|
||
export const FormControlLabel = ({ isRequired, title, help }) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow-up: can be placed to a separate source file
import { Wizard } from 'patternfly-react'; | ||
|
||
import { BasicSettingsTab, onCloseBasic } from './BasicSettingsTab'; | ||
import { VmSettingsTab } from './VmSettingsTab'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too late for following comment as this PR is merged already, but let me just mention it - I am not fan of this renaming as all the settings tabs are bout a VM. The "Basic" denotes context better. And if it eventually contains non-basic options, it can be splitted to a new specialized tab (not recent case, IMO)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed it because it is mouthful. This way, is easier to navigate in the code. We can discuss this and come up with other name - preferably short