This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
Add status component #416
Merged
Add status component #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1691
💛 - Coveralls |
mareklibra
suggested changes
Apr 26, 2019
| <div>This host is under maintenance.</div> | ||
| {maintenanceReason && ( | ||
| <React.Fragment> | ||
| <br /> |
There was a problem hiding this comment.
Wouldn't it be better to use CSS for this?
| <div>{maintenanceReason}</div> | ||
| </React.Fragment> | ||
| )} | ||
| <br /> |
| const overlay = ( | ||
| <Popover id={`${getName(node)}-status-popover`} title="Stopping maintenance"> | ||
| <div>This host is leaving maintenance. It will rejoin the cluster and resume accepting workloads.</div> | ||
| <br /> |
| /> | ||
| ); | ||
| default: | ||
| return false; |
There was a problem hiding this comment.
Can be null returned here?
src/components/VmStatus/VmStatus.js
Outdated
| @@ -21,62 +20,39 @@ import { | |||
| getVmStatus, | |||
| } from '../../utils/status/vm'; | |||
| import { getId, getVmImporterPods } from '../../selectors'; | |||
| import { Status, LinkStatus } from '../Status/Status'; | |||
There was a problem hiding this comment.
just ../Status is enough, let's make use the flexibility given by of the webpack's resolver.
|
@mareklibra fixed all, see new commit. |
mareklibra
approved these changes
Apr 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status component is reused for Vm status, Node status and BareMetalHost status