Skip to content
This repository has been archived by the owner on Apr 28, 2020. It is now read-only.

Fixed the x-axis sequence issue for top projects card #401

Merged
merged 1 commit into from
Apr 24, 2019

Conversation

gnehapk
Copy link
Contributor

@gnehapk gnehapk commented Apr 23, 2019

Description - The x-axis was not plotting the time in sequence if the timestamps aren't same for all namespaces for top projects card.

Before :
top-projects-bug

After fixing:
top-projects-fixed

@coveralls
Copy link

coveralls commented Apr 23, 2019

Pull Request Test Coverage Report for Build 1404

  • 0 of 3 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 86.465%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/selectors/prometheus/storage.js 0 1 0.0%
src/components/StorageOverview/TopConsumers/TopConsumers.js 0 2 0.0%
Totals Coverage Status
Change from base Build 1396: 0.1%
Covered Lines: 3643
Relevant Lines: 4038

💛 - Coveralls

@gnehapk
Copy link
Contributor Author

gnehapk commented Apr 24, 2019

Sent the PR to branch v2.0.0-beta.0. Hence, closing this PR.

@gnehapk gnehapk closed this Apr 24, 2019
@gnehapk
Copy link
Contributor Author

gnehapk commented Apr 24, 2019

Reopening the PR as the backported changes needs to be sent in master too.

@gnehapk gnehapk reopened this Apr 24, 2019
@rawagner rawagner merged commit a1e1375 into kubevirt:master Apr 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants