This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
Drop VM detail edit values on cancel #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1412
💛 - Coveralls |
atiratree
suggested changes
Apr 23, 2019
pcbailey
force-pushed
the
clear-flavor-changes-on-cancel
branch
from
bf60ce6 to
521bcca
Compare
atiratree
reviewed
Apr 24, 2019
atiratree
approved these changes
Apr 24, 2019
pcbailey
force-pushed
the
clear-flavor-changes-on-cancel
branch
from
521bcca to
4efb873
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user entered values into fields in the edit mode of the VM details screen, clicked the Cancel button, and then re-entered edit mode, the previously entered values would still be populated. This PR backs up the saved values before entering edit mode and restores them if editing is cancelled.
Bug: https://bugzilla.redhat.com/1698474