-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
owners, user-guide: set up owners from sigs #819
owners, user-guide: set up owners from sigs #819
Conversation
@dhiller will we setup a job to open update PRs when OWNERS_ALIASES changes in kubevirt/kubevirt? |
50182ff
to
e09520a
Compare
Yeah, I think automation around this would make much sense - not yet sure what exactly we want to do around this. I'd say we store lists inside community repo and sync from there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/hold
Holding to give this some time to be seen
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jean-edouard The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
e09520a
to
59ac930
Compare
Since we have the sigs formed for the several topics, let's establish ownership of the sections by each respective sig. Also we remove some users from the reviewers section who haven't shown review activity for the last six months - this way we avoid assigning them to the reviews and getting reviews stalled. See https://kubevirt.devstats.cncf.io/d/46/pr-reviews-by-contributor?orgId=1&var-period=d7&var-repo_name=kubevirt%2Fuser-guide&var-reviewers=%22davidvossel%22&var-reviewers=%22rmohr%22&var-reviewers=%22stu-gott%22 Signed-off-by: Daniel Hiller <[email protected]>
59ac930
to
1f62117
Compare
/lgtm |
/unhold Noone has complained, so we seem to have reached silent consensus. |
What this PR does / why we need it:
Since we have the sigs formed for the several topics, let's establish ownership of the sections by each respective sig.
This PR adds and
OWNERS_ALIASES
file to capture the several aliases, copying from kubevirt/kubevirt. Also it addsOWNERS
that refer to those sig groups, so that the groups can own the changes to the user-guide themselves.Also it removes some users from the reviewers section who haven't shown
review activity for the last six months - this way we avoid assigning
them to the reviews and getting reviews stalled.
See https://kubevirt.devstats.cncf.io/d/46/pr-reviews-by-contributor?orgId=1&var-period=d7&var-repo_name=kubevirt%2Fuser-guide&var-reviewers=%22davidvossel%22&var-reviewers=%22rmohr%22&var-reviewers=%22stu-gott%22
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/cc @aburdenthehand @cwilkers @alicefr
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: