Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owners, user-guide: set up owners from sigs #819

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

dhiller
Copy link
Contributor

@dhiller dhiller commented Jul 15, 2024

What this PR does / why we need it:

Since we have the sigs formed for the several topics, let's establish ownership of the sections by each respective sig.

This PR adds and OWNERS_ALIASES file to capture the several aliases, copying from kubevirt/kubevirt. Also it adds OWNERS that refer to those sig groups, so that the groups can own the changes to the user-guide themselves.

Also it removes some users from the reviewers section who haven't shown
review activity for the last six months - this way we avoid assigning
them to the reviews and getting reviews stalled.

See https://kubevirt.devstats.cncf.io/d/46/pr-reviews-by-contributor?orgId=1&var-period=d7&var-repo_name=kubevirt%2Fuser-guide&var-reviewers=%22davidvossel%22&var-reviewers=%22rmohr%22&var-reviewers=%22stu-gott%22

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
/cc @aburdenthehand @cwilkers @alicefr

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L do-not-merge/invalid-owners-file labels Jul 15, 2024
@jean-edouard
Copy link
Contributor

@dhiller will we setup a job to open update PRs when OWNERS_ALIASES changes in kubevirt/kubevirt?

@dhiller
Copy link
Contributor Author

dhiller commented Jul 15, 2024

@dhiller will we setup a job to open update PRs when OWNERS_ALIASES changes in kubevirt/kubevirt?

Yeah, I think automation around this would make much sense - not yet sure what exactly we want to do around this. I'd say we store lists inside community repo and sync from there

Copy link
Contributor

@jean-edouard jean-edouard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold
Holding to give this some time to be seen

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jean-edouard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2024
@alicefr
Copy link
Member

alicefr commented Jul 15, 2024

/lgtm
Many thanks @dhiller for the quick PR!

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2024
@dhiller dhiller force-pushed the let-sigs-own-their-sections branch from e09520a to 59ac930 Compare July 17, 2024 11:26
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2024
Since we have the sigs formed for the several topics, let's establish
ownership of the sections by each respective sig.

Also we remove some users from the reviewers section who haven't shown
review activity for the last six months - this way we avoid assigning
them to the reviews and getting reviews stalled.

See https://kubevirt.devstats.cncf.io/d/46/pr-reviews-by-contributor?orgId=1&var-period=d7&var-repo_name=kubevirt%2Fuser-guide&var-reviewers=%22davidvossel%22&var-reviewers=%22rmohr%22&var-reviewers=%22stu-gott%22

Signed-off-by: Daniel Hiller <[email protected]>
@dhiller dhiller force-pushed the let-sigs-own-their-sections branch from 59ac930 to 1f62117 Compare July 17, 2024 11:31
@aburdenthehand
Copy link
Member

/lgtm
Thanks for picking this up @dhiller

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2024
@dhiller
Copy link
Contributor Author

dhiller commented Jul 19, 2024

/unhold

Noone has complained, so we seem to have reached silent consensus.

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2024
@kubevirt-bot kubevirt-bot merged commit 678739d into kubevirt:main Jul 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants