add OCP job to knmstate #304
Conversation
kubevirt-bot
added
dco-signoff: yes
github/ci/prow/files/jobs/nmstate/kubernetes-nmstate-presubmits.yaml
Outdated
Show resolved
Hide resolved
github/ci/prow/files/jobs/nmstate/kubernetes-nmstate-presubmits.yaml
Outdated
Show resolved
Hide resolved
phoracek
force-pushed
the
knmstate_ocp
branch
from
e039718 to
8dd2456
Compare
|
LGTM |
|
We first need to get nmstate/kubernetes-nmstate#337 in |
phoracek
force-pushed
the
knmstate_ocp
branch
from
8dd2456 to
65250e9
Compare
|
/test check-prow-config |
| - release-\d+\.\d+ | ||
| annotations: | ||
| fork-per-release: "true" | ||
| always_run: false |
There was a problem hiding this comment.
It takes a lot of time. Let's just trigger it manually when a PR is ready. It is also "optional" until we make sure it is stable enough.
| - "/usr/local/bin/runner.sh" | ||
| - "/bin/sh" | ||
| - "-c" | ||
| - "yum install -y jq && cat $QUAY_PASSWORD | docker login --username $(cat $QUAY_USER) --password-stdin=true quay.io && automation/check-patch.e2e-ocp.sh" |
There was a problem hiding this comment.
Would be nicer if we instdall jq at the provider not here :-/, so we don't have to do yum install at every lane.
There was a problem hiding this comment.
btw maybe we dont even need to install
on the ocp-4.3 lane of kubevirt we dont install, lets not install and see what happens ?
it would fail directly at the begining of cluster-up since it wont have jq to parse the credits
so we will see it
There was a problem hiding this comment.
Per Or's suggestion, I'm dropping the install for now.
There was a problem hiding this comment.
I am using jq from a container here kubevirt/kubevirtci#231 so it does no tdepend on underlaying system.
We want to test against D/S too. The underlying system and the NetworkManager version there may be different. Also, OCP lane seems to be more stable than OKD. This also mark the OKD lane as optional since it is consistently *not* working. Signed-off-by: Petr Horacek <[email protected]>
phoracek
force-pushed
the
knmstate_ocp
branch
from
65250e9 to
ea456e0
Compare
|
/retest |
1 similar comment
|
/retest |
|
/hold Let's wait for kubevirt/kubevirtci#231 so we don't have to install jq. |
kubevirt-bot
added
the
do-not-merge/hold
|
/hold cancel |
kubevirt-bot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/test check-prow-config |
|
@phoracek: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Or Shoval <[email protected]>
We want to test against D/S too. The underlying system and the
NetworkManager version there may be different. Also, OCP lane seems
to be more stable than OKD.
This also mark the OKD lane as optional since it is consistently
not working.
Signed-off-by: Petr Horacek [email protected]