build multiarch bootstrap image #1149
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| ARG ARCH | ||
| FROM bootstrap-$ARCH | ||
|
|
||
| ENV GIMME_GO_VERSION=1.17.8 | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,121 @@ | ||
| #!/bin/bash -xe | ||
| archs=(amd64 arm64) | ||
|
|
||
| main() { | ||
| local build_only local_base_image | ||
| local_base_image=false | ||
| while getopts "blh" opt; do | ||
| case "$opt" in | ||
| b) | ||
| build_only=true | ||
| ;; | ||
| l) | ||
| local_base_image=true | ||
| ;; | ||
| h) | ||
| help | ||
| exit 0 | ||
| ;; | ||
| *) | ||
| echo "Invalid argument: $opt" | ||
| help | ||
| exit 1 | ||
| esac | ||
| done | ||
| shift $((OPTIND-1)) | ||
| local build_target="${1:?}" | ||
| local registry="${2:?}" | ||
| local registry_org="${3:?}" | ||
| local full_image_name image_tag base_image | ||
|
|
||
| image_tag="$(get_image_tag)" | ||
| full_image_name="$( | ||
| get_full_image_name \ | ||
| "$registry" \ | ||
| "$registry_org" \ | ||
| "${build_target##*/}" \ | ||
| "$image_tag" | ||
| )" | ||
|
|
||
| ( | ||
| cd "$build_target" | ||
| base_image="$(get_base_image)" | ||
|
|
||
| build_image $local_base_image "$build_target" "$full_image_name" "$base_image" | ||
| ) | ||
| [[ $build_only ]] && return | ||
| publish_image "$full_image_name" | ||
| publish_manifest "$full_image_name" | ||
| } | ||
|
|
||
| help() { | ||
| cat <<EOF | ||
| Usage: | ||
| ./publish_multiarch_image.sh [OPTIONS] BUILD_TARGET REGISTRY REGISTRY_ORG | ||
|
|
||
| Build and publish multiarch infra images. | ||
|
|
||
| OPTIONS | ||
| -h Show this help message and exit. | ||
| -b Only build the image and exit. Do not publish the built image. | ||
| -l Use local base image | ||
| EOF | ||
| } | ||
|
|
||
| get_base_image() { | ||
| name="$(cat Dockerfile |grep FROM|awk '{print $2}')" | ||
| echo "${name}" | ||
| } | ||
|
|
||
| get_image_tag() { | ||
| local current_commit today | ||
| current_commit="$(git rev-parse HEAD)" | ||
| today="$(date +%Y%m%d)" | ||
| echo "v${today}-${current_commit:0:7}" | ||
| } | ||
|
|
||
| build_image() { | ||
| local local_base_image=${1:?} | ||
| local build_target="${2:?}" | ||
| local image_name="${3:?}" | ||
| local base_image="${4:?}" | ||
| # add qemu-user-static | ||
| docker run --rm --privileged multiarch/qemu-user-static --reset -p yes | ||
| # build multi-arch images | ||
| for arch in ${archs[*]};do | ||
| if [[ $local_base_image == false ]]; then | ||
brianmcarey marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| docker pull --platform="linux/${arch}" ${base_image} | ||
| fi | ||
| docker build --platform="linux/${arch}" --build-arg ARCH=${arch} --build-arg IMAGE_ARG=${build_target} . -t "${image_name}-${arch}" -t "${build_target}-${arch}" | ||
| done | ||
| } | ||
|
|
||
| publish_image() { | ||
| local full_image_name="${1:?}" | ||
| for arch in ${archs[*]};do | ||
| docker push "${full_image_name}-${arch}" | ||
| done | ||
| } | ||
|
|
||
| publish_manifest() { | ||
| export DOCKER_CLI_EXPERIMENTAL="enabled" | ||
| local amend | ||
| local full_image_name="${1:?}" | ||
| amend="" | ||
| for arch in ${archs[*]};do | ||
| amend+=" --amend ${full_image_name}-${arch}" | ||
| done | ||
| docker manifest create ${full_image_name} ${amend} | ||
|
There was a problem hiding this comment. It would be cool to try this with a tool like buildah but we can try doing that later. Other kubevirt projects are starting to adopt buildah for multi-arch builds - kubevirt/hostpath-provisioner#115 |
||
| docker manifest push --purge ${full_image_name} | ||
| } | ||
|
|
||
| get_full_image_name() { | ||
| local registry="${1:?}" | ||
| local registry_org="${2:?}" | ||
| local image_name="${3:?}" | ||
| local tag="${4:?}" | ||
|
|
||
| echo "${registry}/${registry_org}/${image_name}:${tag}" | ||
| } | ||
|
|
||
| main "$@" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need this option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point - we probably don't need this specific local image flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this flag. For Dockerfile whose baseimage is from remote repository, we need manually pull correct CPU arch base image, otherwise it would use local image even if the local image has different CPU arch with
--platform.For these Dockerfile we use local built image, like the
golangimage, we do not need to pull base image.