Change vbom.ml/util dependeny with github.com/fvbommel/util #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
dco-signoff: yes
oshoval
suggested changes
Sep 8, 2020
|
I would suggest to add the reason (what was the error of vbom and so on to the description) please, |
rhrazdil
force-pushed
the
replace_vbom_dep
branch
from
36e8fc4 to
d1735e7
Compare
kubevirt-bot
added
do-not-merge/invalid-commit-message
release-note-none
|
/approve Holding so @phoracek can have a final word on this. |
kubevirt-bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maiqueb, rhrazdil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
We should address #25 (comment) causing do-not-merge/invalid-commit-message |
Same issue kubernetes/kubectl#925 and corresponding PR kubernetes/kubernetes#94451 suggests to replace the dep with github.com/fvbommel/util Added vbom.ml/util => github.com/fvbommel/util v0.0.0-20180919145318-efcd4e0f9787 to go.mod. Source of the workaround: https://github.com/kubevirt/kubevirt/blob/0a731e884b91d236103ed9c1b5e40db849dfd471/hack/builder/vbom_ml.diff Signed-off-by: Radim Hrazdil <[email protected]>
rhrazdil
force-pushed
the
replace_vbom_dep
branch
from
d1735e7 to
65593d1
Compare
kubevirt-bot
removed
lgtm
|
/lgtm |
|
Looks good, thanks! /hold cancel |
kubevirt-bot
removed
the
do-not-merge/hold
rhrazdil
pushed a commit
to rhrazdil/cluster-network-addons-operator
that referenced
this pull request
Sep 10, 2020
It contains the following PRs:
- Change vbom.ml/util dependency with github.com/fvbommel/util [0]
Fixes vbom dependency
- Adding quotes in macvtap.yaml.in [1]
Allows using yq to edit macvtap.yaml.in
[0] kubevirt/macvtap-cni#25
[1] kubevirt/macvtap-cni#24
Signed-off-by: Radim Hrazdil <[email protected]>
rhrazdil
pushed a commit
to rhrazdil/cluster-network-addons-operator
that referenced
this pull request
Sep 10, 2020
It contains the following PRs:
- Change vbom.ml/util dependency with github.com/fvbommel/util [0]
Fixes vbom dependency
- Adding quotes in macvtap.yaml.in [1]
Allows using yq to edit macvtap.yaml.in
[0] kubevirt/macvtap-cni#25
[1] kubevirt/macvtap-cni#24
Signed-off-by: Radim Hrazdil <[email protected]>
rhrazdil
pushed a commit
to rhrazdil/cluster-network-addons-operator
that referenced
this pull request
Sep 10, 2020
It contains the following PRs:
- Change vbom.ml/util dependency with github.com/fvbommel/util [0]
Fixes vbom dependency
- Adding quotes in macvtap.yaml.in [1]
Allows using yq to edit macvtap.yaml.in
- Fix container command quotes in macvtap.yaml.in [2]
Fixes single quotes in command list
[0] kubevirt/macvtap-cni#25
[1] kubevirt/macvtap-cni#24
[2] kubevirt/macvtap-cni#27
Signed-off-by: Radim Hrazdil <[email protected]>
kubevirt-bot
pushed a commit
to kubevirt/cluster-network-addons-operator
that referenced
this pull request
Sep 10, 2020
* Bump macvtap dep to v0.3.1
It contains the following PRs:
- Change vbom.ml/util dependency with github.com/fvbommel/util [0]
Fixes vbom dependency
- Adding quotes in macvtap.yaml.in [1]
Allows using yq to edit macvtap.yaml.in
- Fix container command quotes in macvtap.yaml.in [2]
Fixes single quotes in command list
[0] kubevirt/macvtap-cni#25
[1] kubevirt/macvtap-cni#24
[2] kubevirt/macvtap-cni#27
Signed-off-by: Radim Hrazdil <[email protected]>
* Add PlacementConfiguration for macvtap
Use Workloads PlacementConfiguration from NetworkAddonsConfig in macvtap pods.
By default, macvtap pods will be scheduled on all nodes.
Signed-off-by: Radim Hrazdil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added vbom.ml/util => github.com/fvbommel/util v0.0.0-20180919145318-efcd4e0f9787
to go.mod.
Signed-off-by: Radim Hrazdil [email protected]
What this PR does / why we need it:
CI fails to get vbom.ml/util dependency
Same issue kubernetes/kubectl#925 and corresponding fix kubernetes/kubernetes#94451 suggests to replace the dep with github.com/fvbommel/util
Source of the used workaround:
https://github.com/kubevirt/kubevirt/blob/0a731e884b91d236103ed9c1b5e40db849dfd471/hack/builder/vbom_ml.diff
Special notes for your reviewer:
Release note: