Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Remove usage of deprecated .spec.running field #79

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

RamLavi
Copy link
Contributor

@RamLavi RamLavi commented Dec 16, 2024

What this PR does / why we need it:
The .spec.running field is deprecated, therefore we should runStrategy instead.

For more info, look at:
kubevirt/kubevirt#11993

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

The .spec.running field is deprecated, therefore we should
runStrategy instead.

For more info, look at:
kubevirt/kubevirt#11993

Signed-off-by: RamLavi <[email protected]>
@kubevirt-bot kubevirt-bot requested a review from oshoval December 16, 2024 08:18
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Dec 16, 2024
@kubevirt-bot kubevirt-bot requested a review from qinqon December 16, 2024 08:18
Copy link
Member

@orelmisan orelmisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @RamLavi

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2024
Copy link
Collaborator

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maiqueb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2024
@RamLavi RamLavi closed this Dec 16, 2024
@RamLavi RamLavi reopened this Dec 16, 2024
@kubevirt-bot kubevirt-bot merged commit 27393f7 into kubevirt:main Dec 16, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants