e2e, persistent-ip: Unify primary,secondary tests (primary UDNs use managedTap) #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
the
dco-signoff: yes
RamLavi
changed the title
RamLavi
changed the title
kubevirt-bot
added
the
needs-rebase
RamLavi
force-pushed
the
unify-primary-secondary-tests
branch
from
fef420c to
222f8f1
Compare
Due to improvements in kubevirt/kubevirt the interface on vmi.status [0] the vmi interface is now published on the vmi.status. This allows retrieving the IPs of the primary UDN interface via the vmi.status. Changing the primary UDN e2e function that retrieves the IPs to use the vmi.status. [0] kubevirt/kubevirt#13018 Signed-off-by: Ram Lavi <[email protected]>
Now that both secondary/primary UDNs get the IPs from the vmi.status, it possible to remove the ipsFrom helper function, and instead use the interface name as a parameter of the test. Doing so unifies and simplifies the e2e tests for both secondary and primary UDNs. Signed-off-by: Ram Lavi <[email protected]>
RamLavi
force-pushed
the
unify-primary-secondary-tests
branch
from
222f8f1 to
2bd3439
Compare
kubevirt-bot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently in the e2e persistent-ips the method of retrieving the IPs from the VM differs between primary and secondary UDN VMs. The reason for the difference is that primary UDN VMs did not support publishing the IPs via VMI.status.
Due to improvements in kubevirt/kubevirt the interface on vmi.status (kubevirt/kubevirt#13018) the vmi interface is now published on the vmi.status - also for primary UDN VMs.
Changing the primary UDN e2e function that retrieves the IPs to use the vmi.status allows us to simplify the e2e by unifying the function that retrieves the VMI IPs.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
This PR relies on #73
Release note: