Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the slack message style #3256

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

nunnatsa
Copy link
Collaborator

@nunnatsa nunnatsa commented Jan 1, 2025

What this PR does / why we need it:

The nightly build status slack message is too large and creates too much noise.

This PR modifies the message style to be smallest:

  1. reduce the size of the header
  2. reduce the size of the emoji, and set it inline with the status text.

also, make dates to be human readable.

Success message example:

image

Failure message example:

image

No-build message example:
image

Jira Ticket:

None

Release note:

None

The nightly build status slack message is too large and creates too much
noise.

This PR modifies the message style to be smallest:
1. reduce the size of the header
2. reduce the size of the emoji, and set it inline with the status text.

also, make dates to be human readable.

Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 1, 2025
@kubevirt-bot kubevirt-bot requested review from orenc1 and sradco January 1, 2025 06:52
Copy link

sonarqubecloud bot commented Jan 1, 2025

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12568174236

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 71.835%

Files with Coverage Reduction New Missed Lines %
controllers/operands/quickStart.go 1 82.14%
Totals Coverage Status
Change from base Build 12560696359: -0.01%
Covered Lines: 6139
Relevant Lines: 8546

💛 - Coveralls

@avlitman
Copy link
Collaborator

avlitman commented Jan 1, 2025

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avlitman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 1, 2025
@avlitman
Copy link
Collaborator

avlitman commented Jan 2, 2025

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2025
@kubevirt-bot kubevirt-bot merged commit 17131a5 into kubevirt:main Jan 2, 2025
15 checks passed
@nunnatsa nunnatsa deleted the improve-slack-msg branch January 2, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants