Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable VolumesUpdateStrategy and VolumeMigration FGs on Kubevirt #3101

Closed

Conversation

tiraboschi
Copy link
Member

Enable VolumesUpdateStrategy and VolumeMigration
feature gates on KubeVirt opinionated deployment.

What this PR does / why we need it:
Enable VolumesUpdateStrategy and VolumeMigration
feature gates on KubeVirt opinionated deployment.

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Jira Ticket:


Release note:

Enable VolumesUpdateStrategy and VolumeMigration feature gates on KubeVirt opinionated deployment.

Enable VolumesUpdateStrategy and VolumeMigration
feature gates on KubeVirt opinionated deployment.

Signed-off-by: Simone Tiraboschi <[email protected]>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Sep 17, 2024
Copy link

@tiraboschi
Copy link
Member Author

/hold
do we really have to do this after kubevirt/community#251 ?

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10909102950

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.776%

Totals Coverage Status
Change from base Build 10828108973: 0.0%
Covered Lines: 5337
Relevant Lines: 6222

💛 - Coveralls

Copy link

openshift-ci bot commented Sep 17, 2024

@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure 1415053 link false /test hco-e2e-upgrade-operator-sdk-sno-azure
ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure 1415053 link true /test hco-e2e-upgrade-prev-operator-sdk-azure
ci/prow/hco-e2e-kv-smoke-azure 1415053 link true /test hco-e2e-kv-smoke-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2024
@kubevirt-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tiraboschi
Copy link
Member Author

Closing for #3191

@tiraboschi tiraboschi closed this Dec 5, 2024
@tiraboschi tiraboschi deleted the enable_kv_volumemigration_fg branch December 5, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants