Add text about using multiple PVCs on a pod with the annotation. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note-none
aglitke
reviewed
Feb 11, 2020
README.md
Outdated
| @@ -14,6 +14,8 @@ The main differences between this provisioner and the standard hostpath provisio | |||
| 3. Or if you do not want to specify the node on the claim, you can specify `volumeBindingMode: WaitForFirstConsumer` in the storage class. Then the PV will be created only when the first Pod using this PVC is scheduled. The PV will be created on the node that the Pod is scheduled on. | |||
| Still, the annotation `kubevirt.io/provisionOnNode` can be used in this mode, though it will not wait for the first consumer. | |||
|
|
|||
| _There is on caveat with using the annotation, if you have a pod that uses multiple PVCs and you annotate one, you should annotate all of them otherwise there can be a race condition where the Kubernetes scheduler can decide to schedule the pod on a node you did not specify in your annotation._ | |||
There was a problem hiding this comment.
I think this could be clarified...
In cases where multiple PVCs are to be used with a Pod it is not recommended to mix the WaitForFirstConsumer binding mode with the provisionOnNode annotation. All of a Pod's PVCs should carry the annotation or none should. Mixing modes can result in PVCs being allocated from different nodes leaving your Pod unschedulable.
awels
force-pushed
the
document_multiple_pvcs_per_pod_with_ann
branch
from
8369cb4
to
73f997b
Compare
|
/retest |
Signed-off-by: Alexander Wels <[email protected]>
awels
force-pushed
the
document_multiple_pvcs_per_pod_with_ann
branch
from
73f997b
to
f2ff491
Compare
aglitke
approved these changes
Mar 11, 2020
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Wels [email protected]
What this PR does / why we need it:
Explain that using the annotation together with multiple PVCs for a single pod can lead to issues if you don't annotate all the PVCs used with the pod.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: