Resize disk image after cloning if we cloned a virtual disk. #938
Conversation
Signed-off-by: Alexander Wels <[email protected]>
kubevirt-bot
added
release-note
|
Think we need a functional test for this? clone a 1G virtual disk into a 2G, the resulting virtual disk should have size 2G |
Pull Request Test Coverage Report for Build 4005
💛 - Coveralls |
| return filesystemCloneProcessor(stream, common.ImporterVolumePath) | ||
| } | ||
|
|
||
| if contentType == BlockdeviceCloneContentType { |
There was a problem hiding this comment.
Jeepers, I can't believe this was an empty if block. My intention was obviously to call blockdeviceCloneProcessor() which is now gone. Should I not be surprised that the data processor is doing the right thing? It's not going to use scratch space, right?
There was a problem hiding this comment.
It doing the right thing, and no it should not be using scratch space, since the pod didn't ask for it. Yeah I was boggled by the empty if, and started implementing it, but then I went, wait a minute, this works, we have tests that explicitly test this for block devices, and they work.
|
/hold |
kubevirt-bot
added
the
do-not-merge/hold
|
This won't work for snapshot cloning. |
kubevirt-bot
added
the
needs-rebase
|
@awels: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Need a different approach for all cloning options. |
Signed-off-by: Alexander Wels [email protected]
What this PR does / why we need it:
Add the ability to resize a clone after the clone finishes and we have cloned a virtual disk image.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #930
Special notes for your reviewer:
Release note: