-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdi-operator updating cdi-apiserver all the time #3489
Conversation
…server Fixing regression introduced in kubevirt#3465 Signed-off-by: Michael Henriksen <[email protected]>
/cherrypick release-v1.60 |
@mhenriks: once the present PR merges, I will cherry-pick it on top of release-v1.60 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-containerized-data-importer-e2e-hpp-previous |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Nice catch, how does the error look like? I imagine lots of these messages?
containerized-data-importer/vendor/kubevirt.io/controller-lifecycle-operator-sdk/pkg/sdk/util.go
Line 156 in ff403fd
logger.Info("DIFF", "obj", objA, "patch", string(pBytes)) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akalenyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mhenriks: new pull request created: #3498 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Make sure TerminationMessagePolicy/Path are set when creating cdi-apiserver
Fixing regression introduced in #3465
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: