Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdi-operator updating cdi-apiserver all the time #3489

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

mhenriks
Copy link
Member

Make sure TerminationMessagePolicy/Path are set when creating cdi-apiserver

Fixing regression introduced in #3465

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Make sure TerminationMessagePolicy/Path are set when creating cdi-apiserver

…server

Fixing regression introduced in kubevirt#3465

Signed-off-by: Michael Henriksen <[email protected]>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 31, 2024
@mhenriks
Copy link
Member Author

/cherrypick release-v1.60

@kubevirt-bot
Copy link
Contributor

@mhenriks: once the present PR merges, I will cherry-pick it on top of release-v1.60 in a new PR and assign it to you.

In response to this:

/cherrypick release-v1.60

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coveralls
Copy link

Coverage Status

coverage: 59.331% (+0.08%) from 59.25%
when pulling ff403fd on mhenriks:fix-cdi-apiserver-event
into e4bc183 on kubevirt:main.

@mhenriks
Copy link
Member Author

/test pull-containerized-data-importer-e2e-hpp-previous

@arnongilboa
Copy link
Collaborator

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2024
Copy link
Collaborator

@akalenyu akalenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Nice catch, how does the error look like? I imagine lots of these messages?

logger.Info("DIFF", "obj", objA, "patch", string(pBytes))
Should we try to write a functest for this? (could be outside this PR)

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akalenyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2024
@kubevirt-bot kubevirt-bot merged commit d9b91dc into kubevirt:main Oct 31, 2024
20 checks passed
@kubevirt-bot
Copy link
Contributor

@mhenriks: new pull request created: #3498

In response to this:

/cherrypick release-v1.60

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants