-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add rook-ceph upstream provisioner string to unsupported providers #3174
fix: add rook-ceph upstream provisioner string to unsupported providers #3174
Conversation
Hi @solacelost. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
bf6820c
to
0b076c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! thanks
/test all
provisioners Signed-off-by: James Harmison <[email protected]>
0b076c8
to
8d78861
Compare
Up to you whether you want to merge this or lump it in with CNV-37744 @arnongilboa - no hard feelings if you just close :) |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-containerized-data-importer-e2e-upg |
What this PR does / why we need it:
This PR adds the upstream rook-ceph RGW StorageClass bucket provisioner to the compiled-in hashmap of unsupported provisioners for the purposes of metrics reporting.
For additional detail, see discussion on #3166
Special notes for your reviewer:
I also separated out the ODF/OCS RGW StorageClass into a dedicated const so that Noobaa is consistent.
Release note: