Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add rook-ceph upstream provisioner string to unsupported providers #3174

Merged

Conversation

solacelost
Copy link
Contributor

What this PR does / why we need it:
This PR adds the upstream rook-ceph RGW StorageClass bucket provisioner to the compiled-in hashmap of unsupported provisioners for the purposes of metrics reporting.

For additional detail, see discussion on #3166

Special notes for your reviewer:
I also separated out the ODF/OCS RGW StorageClass into a dedicated const so that Noobaa is consistent.

Release note:

Improve metrics reporting behavior for upstream rook-ceph deployments, identifying RGW bucket provisioners

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Apr 10, 2024
@kubevirt-bot
Copy link
Contributor

Hi @solacelost. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@solacelost solacelost force-pushed the fix/rook-upstream-storageclass branch from bf6820c to 0b076c8 Compare April 10, 2024 02:37
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Apr 10, 2024
Copy link
Collaborator

@akalenyu akalenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thanks
/test all

@solacelost solacelost force-pushed the fix/rook-upstream-storageclass branch from 0b076c8 to 8d78861 Compare April 10, 2024 14:30
@solacelost
Copy link
Contributor Author

Up to you whether you want to merge this or lump it in with CNV-37744 @arnongilboa - no hard feelings if you just close :)

@arnongilboa
Copy link
Collaborator

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2024
@awels
Copy link
Member

awels commented Apr 11, 2024

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2024
@akalenyu
Copy link
Collaborator

/test pull-containerized-data-importer-e2e-upg

@kubevirt-bot kubevirt-bot merged commit 66afb9b into kubevirt:main Apr 15, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants