Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list of demo materials for easing presentation of KubeVirt at events #42

Merged
merged 5 commits into from
Apr 20, 2020

Conversation

iranzo
Copy link
Contributor

@iranzo iranzo commented Mar 9, 2020

Add index of materials, presentations so that future presenters have a cheatsheet for quick access to resources that can be used in a demonstration of KubeVirt

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Mar 9, 2020
Copy link

@petrkotas petrkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @iranzo thanks for this informative document. Very nice writing.
Would you please review my comments? Otherwise, I believe it is a nice addition.

docs/demomaterials/README.md Outdated Show resolved Hide resolved
docs/demomaterials/README.md Outdated Show resolved Hide resolved
docs/demomaterials/README.md Outdated Show resolved Hide resolved
docs/demomaterials/README.md Outdated Show resolved Hide resolved
docs/demomaterials/README.md Outdated Show resolved Hide resolved
@iranzo
Copy link
Contributor Author

iranzo commented Mar 9, 2020

Thanks @petrkotas new commit uploaded with your comments addressed!

Copy link

@petrkotas petrkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2020
Copy link
Contributor

@ptrnull ptrnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far lgtm, just a comment, some more text above each link when pointing the resources would help the visitor to understand what is he/she going to find when visiting that link.

@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2020
@iranzo
Copy link
Contributor Author

iranzo commented Mar 12, 2020

@ptrnull I've added links with the description instead of the full link, is this what you suggested?

@ptrnull
Copy link
Contributor

ptrnull commented Mar 13, 2020

@iranzo what I meant is to add some more text next explaining what the user may find when visiting that link, for example:
Live Migration: In the user-guide page you may find how to enable Live Migration, it's limitations and some use cases like checking the status of the migration or canceling the migration.

@dankenigsberg
Copy link
Member

Yes. I think that this new page is better linked from somewhere else in this repo

@iranzo
Copy link
Contributor Author

iranzo commented Mar 23, 2020

Yes. I think that this new page is better linked from somewhere else in this repo

Not yet, I'll add to material-overview in repository-root and upload new version, thanks for the suggestion!

@codificat
Copy link
Contributor

/approve

@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codificat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2020
@codificat
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2020
@kubevirt-bot kubevirt-bot merged commit ed0a101 into kubevirt:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants