-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add list of demo materials for easing presentation of KubeVirt at events #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @iranzo thanks for this informative document. Very nice writing.
Would you please review my comments? Otherwise, I believe it is a nice addition.
Thanks @petrkotas new commit uploaded with your comments addressed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far lgtm, just a comment, some more text above each link when pointing the resources would help the visitor to understand what is he/she going to find when visiting that link.
@ptrnull I've added links with the description instead of the full link, is this what you suggested? |
@iranzo what I meant is to add some more text next explaining what the user may find when visiting that link, for example: |
Yes. I think that this new page is better linked from somewhere else in this repo |
Not yet, I'll add to material-overview in repository-root and upload new version, thanks for the suggestion! |
Signed-off-by: Pablo Iranzo Gómez <[email protected]>
Signed-off-by: Pablo Iranzo Gómez <[email protected]>
Signed-off-by: Pablo Iranzo Gómez <[email protected]>
Signed-off-by: Pablo Iranzo Gómez <[email protected]>
Signed-off-by: Pablo Iranzo Gómez <[email protected]>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: codificat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Add index of materials, presentations so that future presenters have a cheatsheet for quick access to resources that can be used in a demonstration of KubeVirt