Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change update strategy of linux-bridge component from static to tagged. #1950

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ashokpariya0
Copy link
Contributor

These changes will allow us to bump the linux-bridge component whenever a new tag is available.

What this PR does / why we need it:
As discussed in the PR #1767, it was necessary to change the update-policy of the linux-bridge component from static to tagged once a new tag is available in containernetworking/plugins. However, it appears that the update-policy is still set to static in this file.

Special notes for your reviewer:
I assume that with the tagged policy, the bump script will be triggered and will use the latest tag from https://github.com/containernetworking/plugins/tags. It will then push the new images to quay.io/kubevirt/cni-default-plugins.

Release note:

None

These changes will allow us to bump the linux-bridge component
whenever a new tag is available.

Signed-off-by: Ashok Pariya <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 16, 2024
@kubevirt-bot
Copy link
Collaborator

Hi @ashokpariya0. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qinqon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@oshoval oshoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to change to tagged only please as far as i remember
the rest is done by the auto bumper

all the other required PRs are merged right ?

@oshoval
Copy link
Collaborator

oshoval commented Dec 16, 2024

for sanity check, you can run with the PR you have now (or latest version better)
CNAO_VERSION=99.0.0 ./hack/components/bump-linux-bridge.sh

and let CI test it, without merging that
better before this PR is merged please (and then revert to the change suggested above, this is just temp test)

@ashokpariya0
Copy link
Contributor Author

for sanity check, you can run with the PR you have now (or latest version better) CNAO_VERSION=99.0.0 ./hack/components/bump-linux-bridge.sh

I see that for the latest tags like v1.6.x (v1.6.0 release), Go version 1.23 is required. However, by default, Go version 1.22.7 is installed. This will require code changes in the Dockerfile.

and let CI test it, without merging that better before this PR is merged please (and then revert to the change suggested above, this is just temp test)

Sure

@oshoval
Copy link
Collaborator

oshoval commented Dec 17, 2024

once you put tagged, and with the current state, the only bump that will occur is directly to latest tagged release
it wont obey the values in the file (iirc)
so we can either static (need to recall who push the images in this case, unless it is the auto bumper)
or to adapt docker and use latest (best if possible please)

EDIT - need to make sure before that, that we can move to go 1.23

@ashokpariya0
Copy link
Contributor Author

once you put tagged, and with the current state, the only bump that will occur is directly to latest tagged release it wont obey the values in the file (iirc) so we can either static (need to recall who push the images in this case, unless it is the auto bumper) or to adapt docker and use latest (best if possible please)

EDIT - need to make sure before that, that we can move to go 1.23

Sure, I will post pr soon, I see few complexities for this, will provide details over pr.

@oshoval
Copy link
Collaborator

oshoval commented Dec 17, 2024

I would say lets go please with the straight forward path first, which is static, with the hash that you used,
like Or Mergi did (i just dont remember who create and push the images in this case)
follow-up can be described in an issue

Thanks

@ashokpariya0
Copy link
Contributor Author

We need to merge the following PR to use the latest tag from the plugin: #1953

@oshoval
Copy link
Collaborator

oshoval commented Dec 17, 2024

Thanks, it can wait for the follow-up
for now lets do please the "static" method ?
(because we would need to check if using newer golang now is allowed before doing #1953)

@ashokpariya0
Copy link
Contributor Author

Thanks, it can wait for the follow-up for now lets do please the "static" method ? (because we would need to check if using newer golang now is allowed before doing #1953)

I'm not sure if I understand correctly, but with the current code, we can't compile the plugin using the latest code tags (e.g., https://github.com/containernetworking/plugins/releases/tag/v1.6.1 and https://github.com/containernetworking/plugins/releases/tag/v1.6.0) because they require Go >= 1.23.

Are you suggesting that we don't need to use the latest code and can instead use the tag https://github.com/containernetworking/plugins/releases/tag/v1.5.1, which works with Go 1.22, and then manually create the image at https://quay.io/repository/kubevirt/cni-default-plugins?tab=tags&tag=latest, posting the change with a static method?

@oshoval
Copy link
Collaborator

oshoval commented Dec 17, 2024

Are you suggesting that we don't need to use the latest code and can instead use the tag https://github.com/containernetworking/plugins/releases/tag/v1.5.1, which works with Go 1.22, and then manually create the image at https://quay.io/repository/kubevirt/cni-default-plugins?tab=tags&tag=latest, posting the change with a static method?

Yep exactly, we just need a recompilation, we don't need all at once atm
i am not sure who build and pushed the image, please ask Or Mergi
if he remember (since he also done like) or on kubevirt slack

alternative is to ask on slack if we can use newest go as you did
I will post this if needed next week on slack, unless you can lead it please meanwhile

Thanks

@oshoval
Copy link
Collaborator

oshoval commented Dec 17, 2024

Will be nice to unblock you, hence the first option might be easier and faster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants