-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change update strategy of linux-bridge component from static to tagged. #1950
base: main
Are you sure you want to change the base?
Change update strategy of linux-bridge component from static to tagged. #1950
Conversation
These changes will allow us to bump the linux-bridge component whenever a new tag is available. Signed-off-by: Ashok Pariya <[email protected]>
Hi @ashokpariya0. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to change to tagged only please as far as i remember
the rest is done by the auto bumper
all the other required PRs are merged right ?
for sanity check, you can run with the PR you have now (or latest version better) and let CI test it, without merging that |
I see that for the latest tags like v1.6.x (v1.6.0 release), Go version 1.23 is required. However, by default, Go version 1.22.7 is installed. This will require code changes in the Dockerfile.
Sure |
once you put tagged, and with the current state, the only bump that will occur is directly to latest tagged release EDIT - need to make sure before that, that we can move to go 1.23 |
Sure, I will post pr soon, I see few complexities for this, will provide details over pr. |
I would say lets go please with the straight forward path first, which is static, with the hash that you used, Thanks |
We need to merge the following PR to use the latest tag from the plugin: #1953 |
Thanks, it can wait for the follow-up |
I'm not sure if I understand correctly, but with the current code, we can't compile the plugin using the latest code tags (e.g., https://github.com/containernetworking/plugins/releases/tag/v1.6.1 and https://github.com/containernetworking/plugins/releases/tag/v1.6.0) because they require Go >= 1.23. Are you suggesting that we don't need to use the latest code and can instead use the tag https://github.com/containernetworking/plugins/releases/tag/v1.5.1, which works with Go 1.22, and then manually create the image at https://quay.io/repository/kubevirt/cni-default-plugins?tab=tags&tag=latest, posting the change with a static method? |
Yep exactly, we just need a recompilation, we don't need all at once atm alternative is to ask on slack if we can use newest go as you did Thanks |
Will be nice to unblock you, hence the first option might be easier and faster |
These changes will allow us to bump the linux-bridge component whenever a new tag is available.
What this PR does / why we need it:
As discussed in the PR #1767, it was necessary to change the update-policy of the linux-bridge component from static to tagged once a new tag is available in containernetworking/plugins. However, it appears that the update-policy is still set to static in this file.
Special notes for your reviewer:
I assume that with the tagged policy, the bump script will be triggered and will use the latest tag from https://github.com/containernetworking/plugins/tags. It will then push the new images to quay.io/kubevirt/cni-default-plugins.
Release note: