Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster/cert-manager-install: Wait for deployments to be ready #1942

Merged
merged 1 commit into from
Jan 9, 2025
Merged

cluster/cert-manager-install: Wait for deployments to be ready #1942

merged 1 commit into from
Jan 9, 2025

Conversation

RamLavi
Copy link
Collaborator

@RamLavi RamLavi commented Dec 15, 2024

What this PR does / why we need it:
Right now if cert-manager deployments fail - we do not know.
Adding appropriate waits.

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 15, 2024
@RamLavi RamLavi requested review from oshoval and removed request for qinqon and phoracek December 15, 2024 07:44
@RamLavi
Copy link
Collaborator Author

RamLavi commented Jan 7, 2025

@oshoval can you take a look?

oshoval
oshoval reviewed Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@oshoval oshoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is nice to have, but wasn't it just because there were other problems that caused it for you locally or so ?

cluster/cert-manager-install.sh Outdated
Comment on lines 26 to 28
./cluster/kubectl.sh wait --namespace cert-manager --for=condition=Available deployment/cert-manager
./cluster/kubectl.sh wait --namespace cert-manager --for=condition=Available deployment/cert-manager-cainjector
./cluster/kubectl.sh wait --namespace cert-manager --for=condition=Available deployment/cert-manager-webhook
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix indent

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

@RamLavi RamLavi force-pushed the add_cert_mng_checks branch from abf6773 to 0c53608 Compare January 9, 2025 07:24
@RamLavi
Copy link
Collaborator Author

RamLavi commented Jan 9, 2025

it is nice to have, but wasn't it just because there were other problems that caused it for you locally or so ?

my (still existing) local issues with fetching quay.io images only revealed the fact we don't check it.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
@RamLavi RamLavi force-pushed the add_cert_mng_checks branch from 0c53608 to 09fb0d4 Compare January 9, 2025 08:31
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
@RamLavi
Copy link
Collaborator Author

RamLavi commented Jan 9, 2025

Change: increased timeout to 5m

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

oshoval
oshoval approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@oshoval oshoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
@RamLavi
Copy link
Collaborator Author

RamLavi commented Jan 9, 2025

/retest
CI failing is unrelated

@RamLavi
Copy link
Collaborator Author

RamLavi commented Jan 9, 2025

/approve

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2025
@kubevirt-bot kubevirt-bot merged commit 06a0b0b into kubevirt:main Jan 9, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshoval oshoval oshoval approved these changes

Assignees

@oshoval oshoval

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RamLavi @kubevirt-bot @oshoval