-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubevirt: Fix deploying kubevirt on git actions #1843
Conversation
Skipping CI for Draft Pull Request. |
/cc @RamLavi |
nope didnt work |
ok seems it is the wait bug, that need to be split |
i think we should move to prow (we have kubevirtci ready, drawback is that we must use old kind atm until we fix prow support for the new one) i am still trying some stuff |
https://github.com/kubevirt/cluster-network-addons-operator/actions/runs/10263335275/job/28395542383?pr=1843
|
Going to try to use kind-ovn kubevirtci provider that already worked on prow when was tested with kubevirt ipam PR due to the new blocking storage problem i could not even reach the state where i want to dump logs / try to deploy less components (which affected prow as well - on prow we could just add memory in this case) |
awesome passed now will rework the PR |
ready for review please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need linux bridge plugin ?
Since we are using git actions, the resources are limited. We saw out of space errors, fix them by cleaning the container before deploying the pods. Also don't deploy some components to free more memory resources. Signed-off-by: Or Shoval <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Quality Gate passedIssues Measures |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oshoval The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-e2e-cluster-network-addons-operator-monitoring-k8 |
@oshoval: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-e2e-cluster-network-addons-operator-monitoring-k8s |
/retest ports already used known problem on CI |
What this PR does / why we need it:
Since we are using git actions, the resources are limited.
We saw out of space errors, fix them by cleaning the container before
deploying the pods.
Also don't deploy some components to free more memory resources.
Special notes for your reviewer:
Fixes #1844
Release note: