Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: unify sql data driver implementation #873

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

chivalryq
Copy link
Member

@chivalryq chivalryq commented Sep 6, 2023

Description of your changes

  1. unify sql data driver implementation
  2. Remove opengause test for upstream remove the action
image

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 3.73% and project coverage change: +0.51% 🎉

Comparison is base (7937d09) 58.48% compared to head (5b385a5) 59.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #873      +/-   ##
==========================================
+ Coverage   58.48%   59.00%   +0.51%     
==========================================
  Files         115      116       +1     
  Lines       20048    19844     -204     
==========================================
- Hits        11725    11708      -17     
+ Misses       6892     6700     -192     
- Partials     1431     1436       +5     
Flag Coverage Δ
apiserver-unittests 32.57% <100.00%> (+0.67%) ⬆️
server-e2e-tests 48.39% <0.00%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/server/infrastructure/datastore/sql/driver.go 0.00% <0.00%> (ø)
pkg/server/infrastructure/datastore/mysql/mysql.go 66.66% <100.00%> (+61.73%) ⬆️
...rver/infrastructure/datastore/postgres/postgres.go 71.42% <100.00%> (+65.23%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NeerajGartia21
Copy link
Collaborator

LGTM !!

@chivalryq chivalryq merged commit d14a2b6 into kubevela:main Sep 7, 2023
14 of 15 checks passed
@chivalryq chivalryq deleted the feat/unify-sql-driver-impl branch September 7, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants