Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Addon] Refactor addon tests CI workflow #410

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

wangyikewxgm
Copy link
Collaborator

@wangyikewxgm wangyikewxgm commented Jul 15, 2022

Now day, our addon test CI workflow has many problems, writen by shell that too dummy, that will enable every addon one-time for every pr costing much time no mater whether what files has been changed.

Description of your changes

This pr refactor whole addon test CI workflow: only test this pr affected addons.

We must consider situations:

  1. Modify fluxcd addon, should test addons those dependent fluxcd addon.
  2. Modify a normal addon, if it dependent fluxcd addon we should enable fluxcd first.
  3. In order to avoid lack of CPU and memory in test env, after test an addon we should disable it.
  4. If a pr changed .workflow , makefile or go file, this pr maybe changed the logic of CI workflow we should test all addons.

How has this code been tested?

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
  • Updated/Added any relevant documentation and examples.
  • New addon should be put in experimental.
  • Update addon should modify the version in metadata.yaml to generate a new version.
  • Any changes about verified addons should be tested with CI script.

@wangyikewxgm wangyikewxgm requested a review from wonderflow as a code owner July 15, 2022 06:20
Signed-off-by: 楚岳 <[email protected]>

add changed files action

Signed-off-by: 楚岳 <[email protected]>

fix path

Signed-off-by: 楚岳 <[email protected]>

more tests

Signed-off-by: 楚岳 <[email protected]>

add 1

Signed-off-by: 楚岳 <[email protected]>

push

finish work let test

Signed-off-by: 楚岳 <[email protected]>

delelte uesless file

Signed-off-by: 楚岳 <[email protected]>

fix

Signed-off-by: 楚岳 <[email protected]>

fix

Signed-off-by: 楚岳 <[email protected]>

fix

Signed-off-by: 楚岳 <[email protected]>

add pending addon

Signed-off-by: 楚岳 <[email protected]>

fix tests

Signed-off-by: 楚岳 <[email protected]>

add commnets

Signed-off-by: 楚岳 <[email protected]>

add test

Signed-off-by: 楚岳 <[email protected]>

more fix

Signed-off-by: 楚岳 <[email protected]>

add more tests

Signed-off-by: 楚岳 <[email protected]>

add more tests

Signed-off-by: 楚岳 <[email protected]>

add test utils

Signed-off-by: 楚岳 <[email protected]>

add commnets

Signed-off-by: 楚岳 <[email protected]>

add more test

Signed-off-by: 楚岳 <[email protected]>

fix flink

Signed-off-by: 楚岳 <[email protected]>

fix istio

Signed-off-by: 楚岳 <[email protected]>

consider downStream addon

Signed-off-by: 楚岳 <[email protected]>

check semver

Signed-off-by: 楚岳 <[email protected]>

fix makefile

Signed-off-by: 楚岳 <[email protected]>
Signed-off-by: 楚岳 <[email protected]>
Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do some manual check

@wangyikewxgm
Copy link
Collaborator Author

wangyikewxgm commented Jul 18, 2022

Please do some manual check

Have tests in my own catalog repo: https://github.com/wangyikewxgm/catalog/pulls, meeting expectation.

@wonderflow wonderflow merged commit 39796f1 into kubevela:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants