Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Addon] Refactor: refactor chartmuseum addon with vela native components #408

Merged
merged 5 commits into from
Jul 15, 2022

Conversation

charlie0129
Copy link
Member

@charlie0129 charlie0129 commented Jul 13, 2022

Signed-off-by: Charlie Chiang [email protected]

Description of your changes

  • Use vela built-in components. No dependencies required, which means we no longer need fluxcd. So users can easily install this in air-gapped environments.
  • Add image parameter to make air-gapped installation possible.
  • Support specifying existing PVC (in addition to auto-generated) to persist data.
  • Delete some inappropriate parameters due to the usage of built-in traits.

How has this code been tested?

Locally tested with some common parameters

Checklist

A tutorial on air-gapped installation of addons is planned.

I have:

  • Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
  • Updated/Added any relevant documentation and examples.
  • New addon should be put in experimental.
  • Update addon should modify the version in metadata.yaml to generate a new version.
  • Any changes about verified addons should be tested with CI script.

@charlie0129 charlie0129 marked this pull request as ready for review July 13, 2022 17:45
Signed-off-by: Charlie Chiang <[email protected]>
@charlie0129 charlie0129 marked this pull request as draft July 14, 2022 00:56
Signed-off-by: Charlie Chiang <[email protected]>
@charlie0129 charlie0129 marked this pull request as ready for review July 14, 2022 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants