-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Offer /metrics and /debug/pprof from controller and agent #68
✨ Offer /metrics and /debug/pprof from controller and agent #68
Conversation
Signed-off-by: Mike Spreitzer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Should we add an option to disable (at list the pprof data) ?
- Why do we need the pprof at different server/port ? can't we just use a different path in the same base URL ?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@MikeSpreitzer /hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added "request changes" just to make sure we resolve the second Q..
@ezrasilvera: yes, my understanding also is that we plan to switch away from controller-runtime. But that is beyond the scope of this PR. Regarding number of sockets, remember that each Pod has its own set of sockets. I do not think we are anywhere near having a problem with the number of sockets open on a given Pod. |
Summary
This PR fills out the matrix of offering /metrics and /debug/pprof from the controller and agent. Previously the only thing offered was /metrics from the agent.
After #67 merges there will be more work to do about /metrics and /debug/pprof in the Helm chart.
Related issue(s)
This is part of addressing kubestellar/kubestellar#2094 and kubestellar/kubestellar#2158