Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Improve apiserver service name for controller manager #76

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

waltforme
Copy link
Contributor

Summary

This PR uses an improved address in the --master flag for the kube-controller-manager inside a controller plane of type k8s.

Before the change, the controller manager failed to verify x509 certificate.

E0726 15:41:22.225385       1 leaderelection.go:327] error retrieving resource lock kube-system/kube-controller-manager: Get "https://consumer0:9444/apis/coordination.k8s.io/v1/namespaces/kube-system/leases/kube-controller-manager?timeout=5s": tls: failed to verify certificate: x509: certificate is valid for kubernetes, kubernetes.default, kubernetes.default.svc, kubernetes.default.svc.cluster, kubernetes.default.svc.cluster.local, localhost, kubeflex-control-plane, consumer0.consumer0-system, consumer0.consumer0-system.svc, consumer0.consumer0-system.svc.cluster, consumer0.consumer0-system.svc.cluster.local, consumer0.localtest.me, not consumer0

After editing the live manifest of the controller manager, the error goes away, e.g.:

         - --master=https://provider.provider-system:9444

Related issue(s)

kubestellar/kubestellar#656

@waltforme waltforme requested a review from pdettori July 26, 2023 17:46
@waltforme
Copy link
Contributor Author

Force push to 5510387 adds -s for git commit to pass the dco-check.

Copy link
Collaborator

@pdettori pdettori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pdettori pdettori merged commit 7a6e189 into kubestellar:main Sep 5, 2023
@waltforme waltforme deleted the cm-flag-master branch December 14, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants