Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add conditions in status #51

Merged
merged 3 commits into from
Jun 19, 2023
Merged

✨ add conditions in status #51

merged 3 commits into from
Jun 19, 2023

Conversation

pdettori
Copy link
Collaborator

Summary

Related issue(s)

Fixes #

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pdettori pdettori merged commit 6a15924 into kubestellar:main Jun 19, 2023
@waltforme
Copy link
Contributor

Quick question: is api/v1alph1/conditions.go written by some code-gen or created by hand?

@pdettori
Copy link
Collaborator Author

It’s written by hand. Not sure there are generators to produce conditions. Some frameworks like Crossplane provide conditions when extending their API.

@waltforme
Copy link
Contributor

I see. Thanks for letting me know these!

@pdettori
Copy link
Collaborator Author

You are welcome @waltforme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants