Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ 'kflex' brew formula #273

Closed
wants to merge 2 commits into from
Closed

Conversation

algoritmoalex
Copy link

Summary

With these changes:

  • our users can use kubeflex and/or kflex formulas
  • kubestellar documentation changes are minimal
  • a date can be set for a planned shutdown of the kubeflex formula if needed
brew install kflex
# shows one can install kubeflex with kflex alias

image

brew upgrade kflex
# shows one can upgrade kubeflex with kflex alias

image

Special consideration

Both kubeflex.rb and kflex.rb brew formulas must be maintained.

Related issue(s)

Fixes #271

Copy link
Collaborator

@pdettori pdettori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@algoritmoalex thank you for submitting this PR. Please note that the kflex.rb file should not be edited directly as it is managed by go releaser, and it is automatically created for each new release. See

- name: kubeflex
homepage: "https://github.com/kubestellar/kubeflex"
tap:
owner: kubestellar
name: kubeflex
branch: brew
pull_request:
enabled: false
commit_author:
name: "{{ .Env.USER }}"
email: "{{ .Env.EMAIL }}"
for the relevant goreleaser code. You can find all the Go releaser brew options here: https://goreleaser.com/customization/homebrew/

@algoritmoalex algoritmoalex marked this pull request as draft July 17, 2024 04:00
@algoritmoalex
Copy link
Author

@pdettori thanks for the clarification. I will review the Go Releaser options and edit over the next few days. For now I have converted the PR to a draft. Please let me know if it is better to close this PR and open a new one instead.

@pdettori
Copy link
Collaborator

@pdettori thanks for the clarification. I will review the Go Releaser options and edit over the next few days. For now I have converted the PR to a draft. Please let me know if it is better to close this PR and open a new one instead.

Thank you @algoritmoalex, both approaches work for me, you may pick the one that works best for you, Thanks!

@pdettori
Copy link
Collaborator

closing as it needs to be re-created with a different approach as outlined on last comment

@pdettori pdettori closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: command is called 'kflex' but brew formula is called 'kubeflex' - pick one please
2 participants