✨Add initContainer to wait for postgresql Ready status #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: francostellari <[email protected]>
|
@pdettori (cc @MikeSpreitzer ) |
francostellari
changed the title
Comment on lines
+27
to
+36
| initContainers: | ||
| - name: wait-postgresql | ||
| image: quay.io/kubestellar/kubectl:1.29.3 | ||
| command: ['sh', '-c'] | ||
| args: | ||
| - | | ||
| while [[ $(kubectl get pods postgres-postgresql-0 -n kubeflex-system -o 'jsonpath={..status.conditions[?(@.type=="Ready")].status}') != "True" ]]; do | ||
| echo "waiting for postgresql pod" | ||
| sleep 5 | ||
| done |
There was a problem hiding this comment.
Why does this need to be here?
There was a problem hiding this comment.
@MikeSpreitzer because operator.yaml is generated from this file by make chart.
Changes made in operator.yaml would be overridden by kustomizer.
| @@ -646,6 +646,18 @@ spec: | |||
| capabilities: | |||
| drop: | |||
| - ALL | |||
| initContainers: | |||
| - args: | |||
| - | | |||
There was a problem hiding this comment.
Why not include this arg along with the other one in command?
There was a problem hiding this comment.
I guess it is a preference, I like to write the script code on multiple lines, easier to copy&past for testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add initContainer to wait for postgresql Ready status.
This prevent kubeflex from acting on CP CRs before the database is ready
This dramatically speedup the creation of CPs and prevent crashes.
Related issue(s)
Fixes #