Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Fix k8.sio/apiserver dependency to match others #206

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

MikeSpreitzer
Copy link
Contributor

Summary

This PR fixes the go.mod to depend on the same release of k8s.io/apiserver as other kubernetes repos.

Related issue(s)

Fixes #

@pdettori
Copy link
Collaborator

Is this related to #207 ? could it introduce those issues with Otel 1.14 ?

@MikeSpreitzer
Copy link
Contributor Author

Merge branch 'main' into go-mod-consistent

We should not be doing that. See https://docs.google.com/document/d/1iwkhpoV76-J-3G-Rif4B1cmL9SWBO_f_fE6WK8jvsDc . I will rebase.

@MikeSpreitzer
Copy link
Contributor Author

This is unrelated to #207. See how the changes here do not mention otel?

Copy link
Collaborator

@pdettori pdettori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@pdettori pdettori merged commit 0b735f8 into kubestellar:main Mar 6, 2024
6 checks passed
@MikeSpreitzer MikeSpreitzer deleted the go-mod-consistent branch March 6, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants