-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add install script #188
✨ Add install script #188
Conversation
Signed-off-by: francostellari <[email protected]> update sudo Signed-off-by: francostellari <[email protected]> update sudo Signed-off-by: francostellari <[email protected]>
d638bab
to
0bb3db7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, but need some adjustment to make it work on macOS - see comment
scripts/install-kubeflex.sh
Outdated
fi | ||
|
||
if [ $strip_bin == "true" ]; then | ||
tar -C $folder -zxf kubeflex.tar.gz --wildcards --strip-components=1 bin/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears that --wildcards option is not supported on macOS. I am getting the error:
$ bash <(curl -s -L https://raw.githubusercontent.com/kubestellar/kubeflex/0bb3db7f20b2c98d1d057bc7fa03132330da6dc0/scripts/install-kubeflex.sh) --ensure-folder /usr/local/bin --strip-bin
tar: Option --wildcards is not supported
Usage:
List: tar -tf <archive-filename>
Extract: tar -xf <archive-filename>
Create: tar -cf <archive-filename> [filenames...]
Help: tar --help
|
||
```shell | ||
sudo su <<EOF | ||
bash <(curl -s https://raw.githubusercontent.com/kubestellar/kubeflex/main/scripts/install-kubeflex.sh) --ensure-folder /usr/local/bin --strip-bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it may be best to add -L
as well to curl to follow redirects
Signed-off-by: francostellari <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Summary
Provide a convenience script to install
kflex
, Kubeflex CLI, without using brew.Related issue(s)
Fixes #