✨ Add --app-version to the goreleaser packaging action
#185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: francostellari <[email protected]>
pdettori
reviewed
Jan 25, 2024
| @@ -61,6 +61,6 @@ jobs: | |||
| - name: Package and push chart | |||
| run: | | |||
| make chart IMG=${{ env.REGISTRY }}/${{ env.OPERATOR_IMAGE }}:${{github.ref_name}} | |||
| helm package ${{ env.CHART_PATH }} --destination . --version ${{github.ref_name}} | |||
| helm push ./*.tgz oci://${{ env.REGISTRY }}/${{ env.IMAGE_NAME }} | |||
| helm package ${{ env.CHART_PATH }} --destination . --version ${{github.ref_name}} --app-version ${{github.ref_name}} --dependency-update | |||
There was a problem hiding this comment.
@francostellari do we need the dependency update even if we do not use the sub-chart ?
|
No but it does not hurt.
I thought to leave it in in case we need it in the future.
If you rather not risk it, I will remove it.
…On Thu, Jan 25, 2024, 12:14 PM Paolo Dettori ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/workflows/goreleaser.yml
<#185 (comment)>:
> @@ -61,6 +61,6 @@ jobs:
- name: Package and push chart
run: |
make chart IMG=${{ env.REGISTRY }}/${{ env.OPERATOR_IMAGE }}:${{github.ref_name}}
- helm package ${{ env.CHART_PATH }} --destination . --version ${{github.ref_name}}
- helm push ./*.tgz oci://${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
+ helm package ${{ env.CHART_PATH }} --destination . --version ${{github.ref_name}} --app-version ${{github.ref_name}} --dependency-update
@francostellari <https://github.com/francostellari> do we need the
dependency update even if we do not use the sub-chart ?
—
Reply to this email directly, view it on GitHub
<#185 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AL5TXIU22ZRDFVVWIJZ6EJDYQKHGTAVCNFSM6AAAAABCKZJQV6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNBUGI3DEOJXGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
We can leave it, it should not make a difference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
--app-versionto the goreleaser packaging actionRelated issue(s)
Fixes #