Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug regex silence will silence all alert #257

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

wanjunlei
Copy link
Collaborator

Fixed bug where regex silence would silence alerts that did not have the match expression key label

For example, all alerts without the label abc will be silenced by the following silence, this is not expected behavior.

apiVersion: notification.kubesphere.io/v2beta2
kind: Silence
metadata:
  name: silence1
  labels:
    type: global
spec:
  matcher:
    matchExpressions:
      - key: abc
        operator: Match
        regexValue: ".*abc"
  startsAt: "2022-02-24T01:15:20Z"
  schedule: ""

@benjaminhuo benjaminhuo merged commit 0c0535a into kubesphere:master Apr 3, 2024
3 checks passed
@benjaminhuo
Copy link
Member

发个 2.5.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants