Users can fill in regular expressions in the parameter #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanjunlei
requested changes
Aug 16, 2023
pkg/apis/v2beta2/common.go
Outdated
| // merge patch. | ||
| // +optional | ||
| Values []string `json:"values,omitempty" protobuf:"bytes,3,rep,name=values"` | ||
| RegexValue string `json:"regexValues,omitempty" protobuf:"bytes,3,rep,name=regexValues"` |
There was a problem hiding this comment.
regexValues => regexValue
There was a problem hiding this comment.
regexValues => regexValue
Yes, should be regexValue
benjaminhuo
reviewed
Aug 17, 2023
benjaminhuo
reviewed
Aug 17, 2023
benjaminhuo
reviewed
Aug 17, 2023
benjaminhuo
reviewed
Aug 17, 2023
benjaminhuo
reviewed
Aug 17, 2023
| "github.com/go-kit/kit/log" | ||
| "github.com/go-kit/kit/log/level" | ||
| "github.com/kubesphere/notification-manager/pkg/apis/v2beta2" |
There was a problem hiding this comment.
Can we change like this to avoid prefix a API call with a version number @wenchajun @wanjunlei :
nm "github.com/kubesphere/notification-manager/pkg/apis/v2beta2"or
nmv2beta2 "github.com/kubesphere/notification-manager/pkg/apis/v2beta2"I prefer the first because we'll needn't change anything when there is a version change.
There was a problem hiding this comment.
The versions of the api are divided into v1beta1 and v2beta2, wouldn't it be confusing to use nm instead of v2beta2?
benjaminhuo
reviewed
Aug 17, 2023
pkg/apis/v2beta2/common.go
Outdated
| LabelSelectorOpMatch LabelSelectorOperator = "Match" | ||
| ) | ||
|
|
||
| func (ls *LabelSelector) Match(label map[string]string) (bool, error) { |
There was a problem hiding this comment.
Should we change Match to Matches to keep consistent with metav1? @wenchajun @wanjunlei
wenchajun
force-pushed
the
regex
branch
3 times, most recently
from
d9e1798 to
6571a33
Compare
Signed-off-by: dehaocheng <[email protected]>
benjaminhuo
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can fill in regular expressions in the parameters to perform regular matching