Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AM-11328: Update the missing parameter description in the OSS docs. #123

Merged
merged 8 commits into from
Aug 16, 2023
Merged

AM-11328: Update the missing parameter description in the OSS docs. #123

merged 8 commits into from
Aug 16, 2023

Conversation

uma-kt
Copy link
Contributor

@uma-kt uma-kt commented Aug 14, 2023

No description provided.

@uma-kt uma-kt requested a review from narmidm August 14, 2023 08:53
veenamj-avesha
veenamj-avesha reviewed Aug 16, 2023
View reviewed changes
Copy link
Contributor

@veenamj-avesha veenamj-avesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left questions on the UI chart and enterprise demo which don't hold good to the OSS edition AFAIK.

Can you address them?

veenamj-avesha
veenamj-avesha approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@veenamj-avesha veenamj-avesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment to address in two files. Rest of the content LGTM. Approving other changes.

Can you fix the comment before merging the PR?

@uma-kt uma-kt merged commit 8b9f977 into master Aug 16, 2023
1 of 2 checks passed
@uma-kt uma-kt deleted the AM-11328 branch August 16, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narmidm narmidm narmidm approved these changes

@veenamj-avesha veenamj-avesha veenamj-avesha approved these changes

@eric978 eric978 Awaiting requested review from eric978 eric978 is a code owner

@that-backend-guy that-backend-guy Awaiting requested review from that-backend-guy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uma-kt @narmidm @veenamj-avesha