Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): add deprecation notice when running a transaction #3069

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

danielbdias
Copy link
Contributor

This PR adds a deprecation notice when running a transaction through the CLI

Changes

  • Added deprecation logic into RunnerRegistry

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@mathnogueira
Copy link
Member

mathnogueira commented Aug 16, 2023

Is it hard to add a test for that? Would be nice to have that covered

@danielbdias danielbdias merged commit 966f266 into main Aug 16, 2023
30 checks passed
@danielbdias danielbdias deleted the add/deprecation-notice-to-transaction-run branch August 16, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants