fix(test): update trace names asserition on Pokeshop #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbdias
changed the title
danielbdias
commented
Jan 17, 2023
| @@ -32,7 +32,7 @@ spec: | |||
| "specs": [ | |||
| { | |||
| "selector": { | |||
| "query": "span[name = \"pg.query:SELECT\"]" | |||
| "query": "span[name = \"pg.query:SELECT pokeshop\"]" | |||
There was a problem hiding this comment.
This line of code owes me 4 hours of life 😝
mathnogueira
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix a change in a dogfood test. As we updated Pokeshop example, one of the spans that we were validating has his name changed.
Context: open-telemetry/opentelemetry-js-contrib#1306 needed to change they way that the spans where reported for
pgChecklist