Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ansi-regex to 4.1.1 #1016

Closed
wants to merge 1 commit into from

Conversation

iblancasa
Copy link

@iblancasa iblancasa commented Jul 28, 2022

Signed-off-by: Israel Blancas [email protected]

Changes

  • Upgrade ansi-regex dependency from 4.1.0 to 4.1.1.

Fixes

Checklist

  • tested locally

Description

The project is using ansi-regex 4.1.0. It seems to be a transitive dependency. That dependency has a vulnerability (CVE-2021-3807). Upgrading it to 4.1.1, solves the problem

Signed-off-by: Israel Blancas <[email protected]>
@xoscar
Copy link
Contributor

xoscar commented Jul 29, 2022

Hey @iblancasa thank you for contributing.

Do you mind providing more information about this change?

Thanks!

@iblancasa
Copy link
Author

iblancasa commented Jul 29, 2022

Sure! @xoscar I updated the first message. Is that OK or more information is needed? Thanks!

@cescoferraro
Copy link
Contributor

cescoferraro commented Jul 31, 2022

Hi @iblancasa, very nice to hear you are interested in the project. 🥇

Your changes would be overwritten, next time any of us run npm install on the project, because this ansi-regex is a dependency of lots of dependencies we use right now. Changing our package-lock.json wont make the problem go away.
Screen Shot 2022-07-31 at 11 14 37
So I think we need to wait for them to update theirs, since we cannot ditch them entirely.
I found this #18713 , where @storybook is planning to solve this issue on the next release. But not sure about the other ones. Latest eslint version also does not includes this solution.
Good thing is that all those dependencies that use ansi-regex are only used at build time at Tracetest, so this should not affect our end users.

If there is anything else you see missing or would like to see on Tracetest, please do not hesitate in contacting us.
We are actively available on the Discord channel

@iblancasa
Copy link
Author

Hi @cescoferraro, I see…
How about adding ansi-regex 4.1.1 to the dependencies in the meantime?

@cescoferraro
Copy link
Contributor

cescoferraro commented Aug 1, 2022

@iblancasa good idea. Although it would solve @types/jest version, cause the newly installed version would dedup [email protected]
This would not solve the issue on @storybook/react that would still use version 2.1.1. Which is also compromised.
Screen Shot 2022-08-01 at 09 21 49
Screen Shot 2022-08-01 at 09 19 17

Screen Shot 2022-08-01 at 09 19 33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants