Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: passing secret as sensitive config #6006

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

rangoo94
Copy link
Member

@rangoo94 rangoo94 commented Nov 5, 2024

Pull request description

kind: TestWorkflow
apiVersion: testworkflows.testkube.io/v1
metadata:
  name: example-workflow
spec:
  steps:
  - name: Run tests
    template:
      name: example-template
      config:
        something: '{{ secret("some-secret", "key") }}'
---
kind: TestWorkflowTemplate
apiVersion: testworkflows.testkube.io/v1
metadata:
  name: example-template
spec:
  config:
    something:
      type: string
      sensitive: true
  steps:
  - shell: echo {{ config.something }}
Zrzut ekranu 2024-11-5 o 16 16 35

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

@rangoo94 rangoo94 requested a review from a team as a code owner November 5, 2024 15:16
@rangoo94 rangoo94 merged commit 797e762 into main Nov 6, 2024
7 checks passed
@rangoo94 rangoo94 deleted the dawid/fix/passing-secrets-as-sensitive-config branch November 6, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants