Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicated logic for container executor #5133

Merged

Conversation

vsukhin
Copy link
Collaborator

@vsukhin vsukhin commented Mar 11, 2024

Pull request description

Fix #5130 Use on;y scheduler logic

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for testkube-docs-preview ready!

Name Link
🔨 Latest commit 5fb770e
🔍 Latest deploy log https://app.netlify.com/sites/testkube-docs-preview/deploys/65ef0aa8840a4d000878a046
😎 Deploy Preview https://deploy-preview-5133--testkube-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.49%. Comparing base (431a60f) to head (10eee2c).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5133      +/-   ##
===========================================
- Coverage    30.18%   26.49%   -3.69%     
===========================================
  Files          347      347              
  Lines        32319    32292      -27     
===========================================
- Hits          9754     8556    -1198     
- Misses       21657    23024    +1367     
+ Partials       908      712     -196     
Flag Coverage Δ
integrationtests ?
unittests 26.49% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vsukhin vsukhin merged commit 0efd12b into develop Mar 11, 2024
14 checks passed
@vsukhin vsukhin deleted the vsukhin/fix/remove-duplicated-container-executor-logic branch March 11, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate args in test job
3 participants