Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install script is broken: due to invalid parameter substitution syntax #4229

Closed
edouard-lopez opened this issue Aug 1, 2023 · 0 comments · Fixed by #4230
Closed

Install script is broken: due to invalid parameter substitution syntax #4229

edouard-lopez opened this issue Aug 1, 2023 · 0 comments · Fixed by #4230
Labels
bug 🐛 Something is not working as should be

Comments

@edouard-lopez
Copy link
Contributor

Describe the bug

-  echo "https://github.com/kubeshop/testkube/releases/download/${version}/testkube_${version:1}_${os}_$arch.tar.gz"
+  echo "https://github.com/kubeshop/testkube/releases/download/${version}/testkube_${version:-1}_${os}_$arch.tar.gz"
  • Download URL need both tag and version which differ by a prefix.
❯ sh ./install.sh
…
./install.sh: 46: Bad substitution

To Reproduce

❯ sh
$ foo="123"
$ echo "bar=${foo}"
bar=123
$ echo "bar=${foo:1}"  
sh: 3: Bad substitution

Expected behavior

The parameter subsitution should happen

Version / Cluster

  • Which testkube version? 699e66c
  • What Kubernetes cluster? irrelevant
  • What Kubernetes version? irrelevant

Screenshots
If applicable, add CLI commands/output to help explain your problem.

Additional context
Add any other context about the problem here.

@edouard-lopez edouard-lopez added the bug 🐛 Something is not working as should be label Aug 1, 2023
edouard-lopez added a commit to edouard-lopez/testkube that referenced this issue Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something is not working as should be
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant