fix: use Testkube logs for telemetry (#4014)

* fix: use Testkube logs for telemetry

* fix: golint

cmd/kubectl-testkube/commands/agent.go

@@ -13,7 +13,9 @@ func NewAgentCmd() *cobra.Command {
 		Use:   "agent",
 		Short: "Testkube Cloud Agent related commands",
 		Run: func(cmd *cobra.Command, args []string) {
-			client, _ := common.GetClient(cmd)
+			client, _, err := common.GetClient(cmd)
+			ui.ExitOnError("getting client", err)
+
 			info, err := client.GetServerInfo()
 			if err != nil {
 				info.Version = info.Version + " " + err.Error()

cmd/kubectl-testkube/commands/agent/debug.go

@@ -28,7 +28,9 @@ func NewAgentDebugCmd() *cobra.Command {
 
 			common.UiPrintContext(cfg)
 
-			client, _ := common.GetClient(cmd)
+			client, _, err := common.GetClient(cmd)
+			ui.ExitOnError("getting client", err)
+
 			i, err := client.GetServerInfo()
 			if err != nil {
 				ui.Errf("Error %v", err)

cmd/kubectl-testkube/commands/artifacts/artifacts.go

@@ -31,7 +31,9 @@ func NewListArtifactsCmd() *cobra.Command {
 		Run: func(cmd *cobra.Command, args []string) {
 			executionID = args[0]
 			cmd.SilenceUsage = true
-			client, _ := common.GetClient(cmd)
+			client, _, err := common.GetClient(cmd)
+			ui.ExitOnError("getting client", err)
+
 			execution, err := client.GetExecution(executionID)
 			var artifacts testkube.Artifacts
 			var errArtifacts error
@@ -65,7 +67,9 @@ func NewDownloadSingleArtifactsCmd() *cobra.Command {
 			filename := args[1]
 			destination := args[2]
 
-			client, _ := common.GetClient(cmd)
+			client, _, err := common.GetClient(cmd)
+			ui.ExitOnError("getting client", err)
+
 			f, err := client.DownloadFile(executionID, filename, destination)
 			ui.ExitOnError("downloading file"+filename, err)
 
@@ -88,7 +92,9 @@ func NewDownloadAllArtifactsCmd() *cobra.Command {
 		Args:  validator.ExecutionName,
 		Run: func(cmd *cobra.Command, args []string) {
 			executionID := args[0]
-			client, _ := common.GetClient(cmd)
+			client, _, err := common.GetClient(cmd)
+			ui.ExitOnError("getting client", err)
+
 			tests.DownloadArtifacts(executionID, downloadDir, format, masks, client)
 		},
 	}

cmd/kubectl-testkube/commands/cloud/connect.go

@@ -36,7 +36,8 @@ func NewConnectCmd() *cobra.Command {
 			// create new cloud uris
 			opts.CloudUris = common.NewCloudUris(opts.CloudRootDomain)
 
-			client, _ := common.GetClient(cmd)
+			client, _, err := common.GetClient(cmd)
+			ui.ExitOnError("getting client", err)
 
 			info, err := client.GetServerInfo()
 			firstInstall := err != nil && strings.Contains(err.Error(), "not found")

cmd/kubectl-testkube/commands/cloud/disconnect.go

@@ -33,7 +33,9 @@ func NewDisconnectCmd() *cobra.Command {
 				return
 			}
 
-			client, _ := common.GetClient(cmd)
+			client, _, err := common.GetClient(cmd)
+			ui.ExitOnError("getting client", err)
+
 			info, err := client.GetServerInfo()
 			firstInstall := err != nil && strings.Contains(err.Error(), "not found")
 			if err != nil && !firstInstall {

cmd/kubectl-testkube/commands/common/client.go

@@ -1,6 +1,7 @@
 package common
 
 import (
+	"errors"
 	"fmt"
 	"os"
 	"strconv"
@@ -10,24 +11,27 @@ import (
 
 	"github.com/kubeshop/testkube/cmd/kubectl-testkube/config"
 	"github.com/kubeshop/testkube/pkg/api/v1/client"
-	"github.com/kubeshop/testkube/pkg/ui"
 )
 
 // GetClient returns api client
-func GetClient(cmd *cobra.Command) (client.Client, string) {
+func GetClient(cmd *cobra.Command) (client.Client, string, error) {
 	clientType := cmd.Flag("client").Value.String()
 	namespace := cmd.Flag("namespace").Value.String()
 	apiURI := cmd.Flag("api-uri").Value.String()
 	oauthEnabled, err := strconv.ParseBool(cmd.Flag("oauth-enabled").Value.String())
-	ui.ExitOnError("parsing flag value", err)
+	if err != nil {
+		return nil, "", fmt.Errorf("parsing flag value %w", err)
+	}
 
 	options := client.Options{
 		Namespace: namespace,
 		ApiUri:    apiURI,
 	}
 
 	cfg, err := config.Load()
-	ui.ExitOnError("loading config file", err)
+	if err != nil {
+		return nil, "", fmt.Errorf("loading config file %w", err)
+	}
 
 	// set kubeconfig as default config type
 	if cfg.ContextType == "" {
@@ -61,7 +65,7 @@ func GetClient(cmd *cobra.Command) (client.Client, string) {
 			}
 
 			if options.Token == nil {
-				ui.ExitOnError("oauth token is empty, please configure your oauth settings first")
+				return nil, "", errors.New("oauth token is empty, please configure your oauth settings first")
 			}
 		}
 	case config.ContextTypeCloud:
@@ -74,7 +78,9 @@ func GetClient(cmd *cobra.Command) (client.Client, string) {
 	}
 
 	c, err := client.GetClient(client.ClientType(clientType), options)
-	ui.ExitOnError("setting up client type", err)
+	if err != nil {
+		return nil, "", fmt.Errorf("setting up client type %w", err)
+	}
 
-	return c, namespace
+	return c, namespace, nil
 }

cmd/kubectl-testkube/commands/common/helper.go

@@ -215,7 +215,9 @@ func KubectlScaleDeployment(namespace, deployment string, replicas int) (string,
 }
 
 func RunMigrations(cmd *cobra.Command) (hasMigrations bool, err error) {
-	client, _ := GetClient(cmd)
+	client, _, err := GetClient(cmd)
+	ui.ExitOnError("getting client", err)
+
 	info, err := client.GetServerInfo()
 	ui.ExitOnError("getting server info", err)
 

cmd/kubectl-testkube/commands/common/validator/version.go

@@ -17,7 +17,11 @@ var ErrOldClientVersion = fmt.Errorf("client version is older than api version,
 func PersistentPreRunVersionCheck(cmd *cobra.Command, clientVersion string) {
 	// version validation
 	// if client version is less than server version show warning
-	client, _ := common.GetClient(cmd)
+	client, _, err := common.GetClient(cmd)
+	if err != nil {
+		return
+	}
+
 	info, err := client.GetServerInfo()
 	if err != nil {
 		// omit check of versions if we can't get server info

cmd/kubectl-testkube/commands/createticket.go

@@ -15,7 +15,9 @@ func NewCreateTicketCmd() *cobra.Command {
 		Short: "Create bug ticket",
 		Long:  "Create an issue of type bug in the Testkube repository",
 		Run: func(cmd *cobra.Command, args []string) {
-			client, _ := common.GetClient(cmd)
+			client, _, err := common.GetClient(cmd)
+			ui.ExitOnError("getting client", err)
+
 			debug, err := debuginfo.GetDebugInfo(client)
 			ui.ExitOnError("get debug info", err)
 			ui.ExitOnError("opening GitHub ticket", github.OpenTicket(debug))

cmd/kubectl-testkube/commands/debug/info.go

@@ -19,7 +19,9 @@ func NewShowDebugInfoCmd() *cobra.Command {
 		Short: "Show debug info",
 		Long:  "Get all the necessary information to debug an issue in Testkube",
 		Run: func(cmd *cobra.Command, args []string) {
-			client, _ := common.GetClient(cmd)
+			client, _, err := common.GetClient(cmd)
+			ui.ExitOnError("getting client", err)
+
 			debug, err := GetDebugInfo(client)
 			ui.ExitOnError("get debug info", err)
 

cmd/kubectl-testkube/commands/download.go

@@ -51,7 +51,9 @@ func NewListArtifactsCmd() *cobra.Command {
 		Run: func(cmd *cobra.Command, args []string) {
 			executionID = args[0]
 			cmd.SilenceUsage = true
-			client, _ := common.GetClient(cmd)
+			client, _, err := common.GetClient(cmd)
+			ui.ExitOnError("getting client", err)
+
 			artifacts, err := client.GetExecutionArtifacts(executionID)
 			ui.ExitOnError("getting artifacts ", err)
 
@@ -78,7 +80,9 @@ func NewDownloadSingleArtifactsCmd() *cobra.Command {
 			filename := args[1]
 			destination := args[2]
 
-			client, _ := common.GetClient(cmd)
+			client, _, err := common.GetClient(cmd)
+			ui.ExitOnError("getting client", err)
+
 			f, err := client.DownloadFile(executionID, filename, destination)
 			ui.ExitOnError("downloading file"+filename, err)
 
@@ -105,7 +109,9 @@ func NewDownloadAllArtifactsCmd() *cobra.Command {
 		Args:    validator.ExecutionName,
 		Run: func(cmd *cobra.Command, args []string) {
 			executionID := args[0]
-			client, _ := common.GetClient(cmd)
+			client, _, err := common.GetClient(cmd)
+			ui.ExitOnError("getting client", err)
+
 			tests.DownloadArtifacts(executionID, downloadDir, format, masks, client)
 		},
 	}

cmd/kubectl-testkube/commands/executors/create.go

@@ -35,7 +35,8 @@ func NewCreateExecutorCmd() *cobra.Command {
 			namespace := cmd.Flag("namespace").Value.String()
 			var client apiClient.Client
 			if !crdOnly {
-				client, namespace = common.GetClient(cmd)
+				client, namespace, err = common.GetClient(cmd)
+				ui.ExitOnError("getting client", err)
 
 				executor, _ := client.GetExecutor(name)
 				if name == executor.Name {

cmd/kubectl-testkube/commands/executors/delete.go

@@ -18,7 +18,9 @@ func NewDeleteExecutorCmd() *cobra.Command {
 		Short: "Delete Executor",
 		Long:  `Delete Executor Resource, pass name to delete by name`,
 		Run: func(cmd *cobra.Command, args []string) {
-			client, _ := common.GetClient(cmd)
+			client, _, err := common.GetClient(cmd)
+			ui.ExitOnError("getting client", err)
+
 			if len(args) > 0 {
 				name = args[0]
 				err := client.DeleteExecutor(name)

cmd/kubectl-testkube/commands/executors/get.go

@@ -25,7 +25,8 @@ func NewGetExecutorCmd() *cobra.Command {
 		Short:   "Gets executor details",
 		Long:    `Gets executor, you can change output format`,
 		Run: func(cmd *cobra.Command, args []string) {
-			client, namespace := common.GetClient(cmd)
+			client, namespace, err := common.GetClient(cmd)
+			ui.ExitOnError("getting client", err)
 
 			firstEntry := true
 			if len(args) > 0 {

cmd/kubectl-testkube/commands/executors/update.go

@@ -24,7 +24,9 @@ func UpdateExecutorCmd() *cobra.Command {
 				ui.Failf("pass valid name (in '--name' flag)")
 			}
 
-			client, namespace := common.GetClient(cmd)
+			client, namespace, err := common.GetClient(cmd)
+			ui.ExitOnError("getting client", err)
+
 			executor, _ := client.GetExecutor(name)
 			if name != executor.Name {
 				ui.Failf("Executor with name '%s' not exists in namespace %s", name, namespace)

cmd/kubectl-testkube/commands/root.go

@@ -66,7 +66,11 @@ var RootCmd = &cobra.Command{
 		clientCfg, err := config.Load()
 		ui.WarnOnError("loading config", err)
 
-		client, _ := common.GetClient(cmd)
+		client, _, err := common.GetClient(cmd)
+		if err != nil {
+			return
+		}
+
 		serverCfg, err := client.GetConfig()
 		ui.WarnOnError("getting config", err)
 

cmd/kubectl-testkube/commands/status.go

@@ -28,7 +28,8 @@ func NewStatusCmd() *cobra.Command {
 				ui.PrintDisabled("Telemetry on CLI", "disabled")
 			}
 
-			client, _ := common.GetClient(cmd)
+			client, _, err := common.GetClient(cmd)
+			ui.ExitOnError("getting client", err)
 
 			config, err := client.GetConfig()
 			ui.ExitOnError("   Getting API config failed", err)

cmd/kubectl-testkube/commands/telemetry/disable.go

@@ -29,7 +29,9 @@ func NewDisableTelemetryCmd() *cobra.Command {
 				ui.PrintDisabled("Telemetry on CLI", "disabled")
 			}
 
-			client, _ := common.GetClient(cmd)
+			client, _, err := common.GetClient(cmd)
+			ui.ExitOnError("getting client", err)
+
 			_, err = client.UpdateConfig(testkube.Config{EnableTelemetry: false})
 
 			if err != nil {

cmd/kubectl-testkube/commands/telemetry/enable.go

@@ -29,7 +29,9 @@ func NewEnableTelemetryCmd() *cobra.Command {
 				ui.PrintEnabled("Telemetry on CLI", "enabled")
 			}
 
-			client, _ := common.GetClient(cmd)
+			client, _, err := common.GetClient(cmd)
+			ui.ExitOnError("getting client", err)
+
 			_, err = client.UpdateConfig(testkube.Config{EnableTelemetry: true})
 
 			if err != nil {

cmd/kubectl-testkube/commands/telemetry/status.go

@@ -24,7 +24,8 @@ func NewStatusTelemetryCmd() *cobra.Command {
 				ui.PrintDisabled("Telemetry on CLI", "disabled")
 			}
 
-			client, _ := common.GetClient(cmd)
+			client, _, err := common.GetClient(cmd)
+			ui.ExitOnError("getting client", err)
 
 			config, err := client.GetConfig()
 			ui.ExitOnError("   Getting API config failed", err)

cmd/kubectl-testkube/commands/tests/abort.go

@@ -18,9 +18,10 @@ func NewAbortExecutionCmd() *cobra.Command {
 		Run: func(cmd *cobra.Command, args []string) {
 			executionID := args[0]
 
-			client, _ := common.GetClient(cmd)
+			client, _, err := common.GetClient(cmd)
+			ui.ExitOnError("getting client", err)
 
-			err := client.AbortExecution("test", executionID)
+			err = client.AbortExecution("test", executionID)
 			ui.ExitOnError(fmt.Sprintf("aborting execution %s", executionID), err)
 			ui.SuccessAndExit("Succesfully aborted test", executionID)
 		},
@@ -35,9 +36,10 @@ func NewAbortExecutionsCmd() *cobra.Command {
 		Run: func(cmd *cobra.Command, args []string) {
 			testName := args[0]
 
-			client, _ := common.GetClient(cmd)
+			client, _, err := common.GetClient(cmd)
+			ui.ExitOnError("getting client", err)
 
-			err := client.AbortExecutions(testName)
+			err = client.AbortExecutions(testName)
 			ui.ExitOnError(fmt.Sprintf("aborting executions of test %s", testName), err)
 			ui.SuccessAndExit("Succesfully aborted all executions of the test", testName)
 		},

cmd/kubectl-testkube/commands/tests/create.go

@@ -89,7 +89,9 @@ func NewCreateTestsCmd() *cobra.Command {
 			namespace := cmd.Flag("namespace").Value.String()
 			var client client.Client
 			if !crdOnly {
-				client, namespace = common.GetClient(cmd)
+				client, namespace, err = common.GetClient(cmd)
+				ui.ExitOnError("getting client", err)
+
 				test, _ := client.GetTest(testName)
 
 				if testName == test.Name {

cmd/kubectl-testkube/commands/tests/delete.go

@@ -19,7 +19,9 @@ func NewDeleteTestsCmd() *cobra.Command {
 		Short:   "Delete Test",
 		Run: func(cmd *cobra.Command, args []string) {
 
-			client, _ := common.GetClient(cmd)
+			client, _, err := common.GetClient(cmd)
+			ui.ExitOnError("getting client", err)
+
 			namespace := cmd.Flag("namespace").Value.String()
 			if deleteAll {
 				err := client.DeleteTests("")

cmd/kubectl-testkube/commands/tests/executions.go

@@ -26,7 +26,8 @@ func NewGetExecutionCmd() *cobra.Command {
 		Short:   "Lists or gets test executions",
 		Long:    `Getting list of execution for given test name or recent executions if there is no test name passed`,
 		Run: func(cmd *cobra.Command, args []string) {
-			client, _ := common.GetClient(cmd)
+			client, _, err := common.GetClient(cmd)
+			ui.ExitOnError("getting client", err)
 
 			if len(args) == 1 {
 				executionID := args[0]

cmd/kubectl-testkube/commands/tests/get.go

@@ -27,7 +27,8 @@ func NewGetTestsCmd() *cobra.Command {
 		Long:    `Getting all available tests from given namespace - if no namespace given "testkube" namespace is used`,
 		Run: func(cmd *cobra.Command, args []string) {
 			namespace := cmd.Flag("namespace").Value.String()
-			client, _ := common.GetClient(cmd)
+			client, _, err := common.GetClient(cmd)
+			ui.ExitOnError("getting client", err)
 
 			var name string
 			firstEntry := true

cmd/kubectl-testkube/commands/tests/run.go

@@ -106,7 +106,8 @@ func NewRunTestCmd() *cobra.Command {
 			}
 
 			var executions []testkube.Execution
-			client, namespace := common.GetClient(cmd)
+			client, namespace, err := common.GetClient(cmd)
+			ui.ExitOnError("getting client", err)
 
 			options := apiv1.ExecuteTestOptions{
 				ExecutionVariables:         variables,