fix: map test suite YAML to proper update structure (#4129)

kubeshop · Jul 5, 2023 · 385c888 · 385c888
1 parent e745002
commit 385c888
Show file tree

Hide file tree

Showing 2 changed files with 55 additions and 4 deletions.
diff --git a/pkg/mapper/testsuites/kube_openapi.go b/pkg/mapper/testsuites/kube_openapi.go
@@ -225,10 +225,10 @@ func MapTestSuiteTestCRDToUpdateRequest(testSuite *testsuitesv3.TestSuite) (requ
 	request.Before = &before
 
 	steps := mapCRDToTestBatchSteps(testSuite.Spec.Steps)
-	request.Before = &steps
+	request.Steps = &steps
 
 	after := mapCRDToTestBatchSteps(testSuite.Spec.After)
-	request.Before = &after
+	request.After = &after
 
 	request.Labels = &testSuite.Labels
 

diff --git a/pkg/mapper/testsuites/kube_openapi_test.go b/pkg/mapper/testsuites/kube_openapi_test.go
@@ -19,7 +19,7 @@ func TestMapTestSuiteListKubeToAPI(t *testing.T) {
 					{
 						Execute: []testsuitesv3.TestSuiteStepSpec{
 							{
-								Delay: metav1.Duration{Duration: time.Second},
+								Delay: metav1.Duration{Duration: 2 * time.Second},
 							},
 						},
 					},
@@ -50,7 +50,58 @@ func TestMapTestSuiteListKubeToAPI(t *testing.T) {
 		},
 	)
 
-	assert.Equal(t, 1, len(openAPITest.Steps))
 	assert.Equal(t, 1, len(openAPITest.Before))
+	assert.Equal(t, "2s", openAPITest.Before[0].Execute[0].Delay)
+	assert.Equal(t, 1, len(openAPITest.Steps))
+	assert.Equal(t, "some-test-name", openAPITest.Steps[0].Execute[0].Test)
 	assert.Equal(t, 1, len(openAPITest.After))
+	assert.Equal(t, "1s", openAPITest.After[0].Execute[0].Delay)
+}
+
+func TestMapTestSuiteTestCRDToUpdateRequest(t *testing.T) {
+
+	openAPITest := MapTestSuiteTestCRDToUpdateRequest(
+		&testsuitesv3.TestSuite{
+			Spec: testsuitesv3.TestSuiteSpec{
+				Before: []testsuitesv3.TestSuiteBatchStep{
+					{
+						Execute: []testsuitesv3.TestSuiteStepSpec{
+							{
+								Delay: metav1.Duration{Duration: 2 * time.Second},
+							},
+						},
+					},
+				},
+
+				Steps: []testsuitesv3.TestSuiteBatchStep{
+					{
+						Execute: []testsuitesv3.TestSuiteStepSpec{
+							{
+								Test: "some-test-name",
+							},
+						},
+					},
+				},
+
+				After: []testsuitesv3.TestSuiteBatchStep{
+					{
+						Execute: []testsuitesv3.TestSuiteStepSpec{
+							{
+								Delay: metav1.Duration{Duration: time.Second},
+							},
+						},
+					},
+				},
+
+				Repeats: 2,
+			},
+		},
+	)
+
+	assert.Equal(t, 1, len(*openAPITest.Before))
+	assert.Equal(t, "2s", (*openAPITest.Before)[0].Execute[0].Delay)
+	assert.Equal(t, 1, len(*openAPITest.Steps))
+	assert.Equal(t, "some-test-name", (*openAPITest.Steps)[0].Execute[0].Test)
+	assert.Equal(t, 1, len(*openAPITest.After))
+	assert.Equal(t, "1s", (*openAPITest.After)[0].Execute[0].Delay)
 }