refactor: changed theme color and styling #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tional (#665) * fix: use only one executor object per executor in the Redux slice Resolves: kubeshop/testkube#3831 * fix: make private registry not required for the executor Resolves: kubeshop/testkube#3830
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rangoo94
reviewed
May 15, 2023
| @@ -1,7 +1,7 @@ | |||
| import styled from 'styled-components'; | |||
|
|
|||
| export const StyledPre = styled.pre` | |||
| padding: 12px 40px 12px 12px; | |||
| padding: 12px 0 12px 12px; | |||
There was a problem hiding this comment.
Wouldn't be better to keep the same padding both on left and right side?
Suggested change
| padding: 12px 0 12px 12px; | |
| padding: 12px; |
There was a problem hiding this comment.
In my opinion it's not needed. padding-right seems redundant as I've shown on screenshots
There was a problem hiding this comment.
On the screenshot it looks like it's not redundant - there is no space between a button and end of text
There was a problem hiding this comment.
We already have padding on the button to the right. IMO it's totally sufficient to have padding only there. Ofc it's not a big deal to add this padding there.
There was a problem hiding this comment.
It's padding inside the button, not the margin outside. I'm not a designer though, so probably better to ask @fivenp :)
Comment on lines
+15
to
+16
| flex: 1; | ||
|
|
There was a problem hiding this comment.
Are you sure that it should be applied to all FormItems? Additionally, most likely it means that some existing rules like width: 100% should not be needed.
There was a problem hiding this comment.
I checked and did not find any FormItems with width: 100% CSS rule. Did you mean this?
There was a problem hiding this comment.
I meant FormItem items that sometimes were enforcing width, because keeping FormItems width was to small for it, although I may be wrong anyway 👍
There was a problem hiding this comment.
Again, I did not see FormItems with enforced width.
There was a problem hiding this comment.
I meant FormItem children, not FormItem itself 🙂
haneabogdan
approved these changes
May 16, 2023
haneabogdan
added a commit
that referenced
this pull request
May 18, 2023
* feat: connect to testkube cloud (#667) * fix: show latest data in execution details / make private registry optional (#665) * fix: use only one executor object per executor in the Redux slice Resolves: kubeshop/testkube#3831 * fix: make private registry not required for the executor Resolves: kubeshop/testkube#3830 * fix: hide form from executor name & type (#664) Resolves: kubeshop/testkube#3830 * refactor: changed theme color and styling --------- Co-authored-by: Bogdan Hanea <[email protected]> Co-authored-by: Dawid Rusnak <[email protected]> Co-authored-by: ediv <[email protected]>
vsukhin
pushed a commit
that referenced
this pull request
Jun 1, 2023
* feat: connect to testkube cloud (#667) * fix: show latest data in execution details / make private registry optional (#665) * fix: use only one executor object per executor in the Redux slice Resolves: kubeshop/testkube#3831 * fix: make private registry not required for the executor Resolves: kubeshop/testkube#3830 * fix: hide form from executor name & type (#664) Resolves: kubeshop/testkube#3830 * feat: enable NGINX IPv6 (#663) * chore: update docs links (#662) * Release v1.11.0 (#648) * test ci to develop (#634) * test ci (#635) * remove sha (#636) * docs: delete legacy Netlify deployment (#637) * fix: get test-suite list after creation (#639) * fix: run GitHub workflows for develop PRs too (#640) * feat: stop sending the hostname to the Segment.io (#641) * fix: some forms had never enabled "Save" button (#643) * update ci for tag creation (#644) * fix: adjust build release workflow (#649) Co-authored-by: ypoplavs <[email protected]> * Multiple test/test-suite execution abortion (#638) * ui for all execution abortion * abortion on details page * added abortion on list * remove dropdown bg customization * wrapper style in dots dropdown * remove on hover trigger * commented the merge of release branch for now * fix typo * command input consistency (#651) * refactor: enhanced copy command (#652) Co-authored-by: ediv <[email protected]> * Types (#642) * refactor: adjusted typings in many places * refactor: deleted redundant import and @src * refactor: changes according to comments on PR * refactor: changes according to comments on PR * refactor: changes according to comments on PR from Dawid * refactor: changes according to comments on PR from Dawid * refactor: fixed github job * refactor: changes due to comments on PR --------- Co-authored-by: ediv <[email protected]> * fix: deleted a redundant row from entity grid item (#654) Co-authored-by: ediv <[email protected]> * feat: added a custom space component (#660) * feat: added a custom space component * feat: renamed the component according to comment on PR --------- Co-authored-by: ediv <[email protected]> * fix: show axis for executions even when there is a lot of them (#659) Resolves: kubeshop/testkube#3466 * fix: immediately return new data from RTK (#658) Resolves: kubeshop/testkube#3776 * fix: round test duration correctly (#657) * fix: round test duration correctly Resolves: kubeshop/testkube#3743 * fixup test * fix: allow dots in k8s resource names (#656) Resolves: kubeshop/testkube#3816 * fix: glitching skeleton animation (#655) * fix: glitching skeleton animation * fixup lint * fix: use Git tokens and Git usernames correctly for the Test Sources (#653) * fix: create test source with Git token correctly * fix: updating git token/username in the test source details * fix: show repository URL for the proper source * use FullWidthSpace Resolves: testkube#3810 * fix: some console errors (#661) * fix: show latest data in execution details / make private registry optional (#665) * fix: use only one executor object per executor in the Redux slice Resolves: kubeshop/testkube#3831 * fix: make private registry not required for the executor Resolves: kubeshop/testkube#3830 * fix: hide form from executor name & type (#664) Resolves: kubeshop/testkube#3830 * feat: enable NGINX IPv6 (#663) * chore: update docs links (#662) --------- Co-authored-by: ypoplavs <[email protected]> Co-authored-by: Bogdan Hanea <[email protected]> Co-authored-by: Pavlo Burchak <[email protected]> Co-authored-by: ypoplavs <[email protected]> Co-authored-by: Toxer10 <[email protected]> Co-authored-by: ediv <[email protected]> Co-authored-by: ahmedimf1 <[email protected]> Co-authored-by: Abdallah Abedraba <[email protected]> * feat: dashboard E2E tests migrated from main repo (#669) * E2E tests migrated from main repo * E2E tests migrated from main repo - dir change * updated after linter * updated after linter * updated after linter * typo fixed * semicolons * fixes after eslint * fixes after eslint * ci: rename release branch (#673) * rename release branch * ci: rename release branch (#672) * rename release branch * feat: connect to testkube cloud (#667) * feat: dashboard E2E tests migrated from main repo (#669) * E2E tests migrated from main repo * E2E tests migrated from main repo - dir change * updated after linter * updated after linter * updated after linter * typo fixed * semicolons * fixes after eslint * fixes after eslint * refactor: changed theme color and styling (#668) * feat: connect to testkube cloud (#667) * fix: show latest data in execution details / make private registry optional (#665) * fix: use only one executor object per executor in the Redux slice Resolves: kubeshop/testkube#3831 * fix: make private registry not required for the executor Resolves: kubeshop/testkube#3830 * fix: hide form from executor name & type (#664) Resolves: kubeshop/testkube#3830 * refactor: changed theme color and styling --------- Co-authored-by: Bogdan Hanea <[email protected]> Co-authored-by: Dawid Rusnak <[email protected]> Co-authored-by: ediv <[email protected]> * feat: add ModalOutletProvider that's automatically injecting the ModalOutlet (#670) * fix naming (#677) * fix: E2E tests - fix tests after eslint fixes (#676) * feat: connect to testkube cloud (#667) * fix: show latest data in execution details / make private registry optional (#665) * fix: use only one executor object per executor in the Redux slice Resolves: kubeshop/testkube#3831 * fix: make private registry not required for the executor Resolves: kubeshop/testkube#3830 * fix: hide form from executor name & type (#664) Resolves: kubeshop/testkube#3830 * feat: enable NGINX IPv6 (#663) * chore: update docs links (#662) * feat: dashboard E2E tests migrated from main repo (#669) * E2E tests migrated from main repo * E2E tests migrated from main repo - dir change * updated after linter * updated after linter * updated after linter * typo fixed * semicolons * fixes after eslint * fixes after eslint * ci: rename release branch (#672) * rename release branch * typo fixed --------- Co-authored-by: Bogdan Hanea <[email protected]> Co-authored-by: Dawid Rusnak <[email protected]> Co-authored-by: ahmedimf1 <[email protected]> Co-authored-by: Abdallah Abedraba <[email protected]> Co-authored-by: ypoplavs <[email protected]> * fix: fixed home page UI (#679) Co-authored-by: ediv <[email protected]> * fix: enable IPv6 for nginx only when ENABLE_IPV6 is set to true (#680) Relates to: kubeshop/testkube#3846 * fix: enable IPv6 for nginx only when ENABLE_IPV6 is set to true (#683) Relates to: kubeshop/testkube#3846 * tech: used FullWidthSpace instead of StyledSpace with inline width (#681) Co-authored-by: ediv <[email protected]> * Utilize external links (#686) * utilize external links * fix type * add timeout doc * fix sider links (#687) * Move error reports into the area where they were triggered (#685) * notifications in cards * validation fix * refactored error handling, added scroll to notification * refactor notification flow * set null error on submit Co-authored-by: Dawid Rusnak <[email protected]> --------- Co-authored-by: Dawid Rusnak <[email protected]> * tech: read PostHog, Segment and GA4 keys from env variables (#688) * tech: read PostHog, Segment and GA4 keys from env variables * replace with created secrets Resolves: kubeshop/testkube#3875 * fix: avoid sending Referer header (#691) Related to: kubeshop/testkube#3612 * feat: add contact Us external link (#694) * feat: implemented OSS to Cloud hints for OSS (#690) * feat: implemented OSS to Cloud hints for OSS * feat: changes according to comments on PR * feat: changes due to comments on PR * feat: changes due to comments on PR * feat: adjusted stylelint rule * feat: adjusted stylelint * feat: changes due to comments on PR * feat: changes due to comments on PR --------- Co-authored-by: ediv <[email protected]> * feat: add REACT_APP_DISABLE_TELEMETRY to force disabling telemetry (#692) Related to: kubeshop/testkube#3884 * feat: report Git version in telemetry (#693) * feat: use Git version for analytics Resolves: kubeshop/testkube#3881 * feat: expose app version in meta[app-version] * feat: send app version to PostHog too Resolves: kubeshop/testkube#3887 * feat: avoid processing IP in PostHog * fix: fixed cloud banner on Cloud (#695) Co-authored-by: ediv <[email protected]> * ci: update gh token var (#696) * feat: adjusted FullWidthSpace component, added new prop (#697) * feat: adjusted FullWidthSpace component, added new prop * tech: added a new color * tech: changed the color * tech: changes due to comments on PR --------- Co-authored-by: ediv <[email protected]> * ci: add docker registry description (#699) * add GH for uploading readme to dockerhub registry * feat: integrate Prettier (#698) * chore: update Prettier - new version supports --cache flag * feat: move Prettier configuration to JS file and adjust import orders * chore: rename deprecated Prettier option * feat: run Prettier formatting on pre-commit Resolves: kubeshop/testkube#3709 * feat: add cache for ESLint * feat: check Prettier formatting on CI/CD * chore: run Prettier against the source * fix: delete unused parts of package.json * fix: make whole page scrollable (#701) * fix: make whole page scrollable Resolves: kubeshop/testkube#3901 * chore: delete unnecessary overflow * fix: align paddings of the notification wrapper * fix: make html & body full height too * fix: make sider scrollable too on smaller devices * Allow using Prettier from different dir (#704) * Labels improvements (#702) * labels improvements * refactored labels multiselect * fix default labels props * fixes after review * Implement Triggers store in Zustand (#703) * triggers zustand * local trigger store * remove files and renaming * prettier fix --------- Co-authored-by: Bogdan Hanea <[email protected]> * ci: add workflow dispatch (#706) * fix: fixed dropdown styles (#705) Co-authored-by: ediv <[email protected]> * fix: fixed dropdown UI (#707) Co-authored-by: ediv <[email protected]> * fix: fixed a problem reported by Tomek (#709) Co-authored-by: ediv <[email protected]> * tech: make Zustand contextual (#710) * feat: add utilities for local Zustand stores and use it for Triggers * feat: create combined store for Dashboard * feat: inject combined store for whole Dashboard * fix: show existing Test Suite steps (#714) Resolves: kubeshop/testkube#3940 * fix: allow non-root user for the Docker image (#708) Resolves: kubeshop/testkube#3931 * fix: avoid infinite recursion due to always truthy update on error (#715) * feat: add overrides mechanism for testing variables (#716) * feat: add overrides mechanism for testing variables Resolves: kubeshop/testkube#3948 * typo: rename hasOverridesApplied to areOverridesApplied --------- Co-authored-by: Bogdan Hanea <[email protected]> Co-authored-by: Dawid Rusnak <[email protected]> Co-authored-by: ahmedimf1 <[email protected]> Co-authored-by: Abdallah Abedraba <[email protected]> Co-authored-by: Pavlo Burchak <[email protected]> Co-authored-by: Toxer10 <[email protected]> Co-authored-by: ediv <[email protected]> Co-authored-by: Tomasz Konieczny <[email protected]> Co-authored-by: Tomasz Konieczny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now disabled button (1) looks better and consistant with
Form.Items,CopyCommandhas more space for command (2) and customFormItemnow has more gereral styles.For 1:
For 2:
Prev:
Now:
