#2442 - fix issues with k8s access related to admission controller validated resources #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urces leading to blocking k8s access or other internal issues
f1ames
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
LGTM 👍
Just for clarity, as @murarustefaan mentioned on Slack:
I went with the approach of including resources in the validatingwebhookconfiguration rather than excluding inside it because having everything validated yet excluding stuff at runtime does present a risk, namely the case where the controller pod is down, it would block access to multiple resources rather than just the ones validated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…urces leading to blocking k8s access or other internal issues
This PR...
Changes
Fixes
Checklist