Hide private channel names in show config command
#1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszostok
approved these changes
Jul 3, 2024
pkg/config/config.go
Outdated
Comment on lines
203
to
204
| // ChannelID is the Slack ID of the channel. | ||
| ChannelID string `yaml:"channelID"` |
There was a problem hiding this comment.
why do we have it? Slack is based on channel name 🤔
There was a problem hiding this comment.
Added comment: 0d65e00 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
show configcommandPreview
Testing
Run the changes E2E with other pull requests. Instructions there.
Related issue(s)
https://github.com/kubeshop/botkube-cloud/issues/1165